Lobby bot (XPartaMupp) - remove dead games

[elexis]

Sometimes games don't become unregistered correctly and thus will be listed in the lobby until the bot is restarted.

We should implement some timeout value, so that they become unlisted if we don't hear from them after some meaningful time (10min?).

Users who know they will be banned use this to show their game in the lobby.

[elexis]

Notice three dead games of that user being listed for the lifespan of WfgBot.

[elexis]

The game should already be removed when the player leaves, according to the code:

  def muc_offline(self, presence):
    """
    Process presence stanza from a chat room.
    """
    # Clean up after a player leaves
    if presence['muc']['nick'] != self.nick:
      # Delete any games they were hosting.
      for JID in self.gameList.getAllGames():
        if JID == str(presence['muc']['jid']):
          self.gameList.removeGame(JID)
          self.sendGameList()
          break
      # Remove them from the local player list.
      self.lastLeft = str(presence['muc']['jid'])
      if str(presence['muc']['jid']) in self.nicks:
        del self.nicks[str(presence['muc']['jid'])]

[elexis]

Is still the case as of alpha 20 when banning a user (alpha 20 lobby with r18609 applied).

[wraitii]

Need clarification but I think we know clear out games when players disconnect, which ought be good enough to GC everything -> this might be fixed