Changes between Initial Version and Version 1 of Ticket #3551, comment 3


Ignore:
Timestamp:
Oct 31, 2015, 5:28:39 AM (4 years ago)
Author:
Josh
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #3551, comment 3

    initial v1  
    1 Looks good. I would recommend a few more validation checks in Player.js. One would be to make sure that the lobby is running before enabling ranking. If the lobby is not running, a warning or error on attempt to enable ranking seems appropriate.
     1~~Looks good. I would recommend a few more validation checks in Player.js. One would be to make sure that the lobby is running before enabling ranking. If the lobby is not running, a warning or error on attempt to enable ranking seems appropriate.~~
     2
     3Edit: Are you sure that you want to make it a property of the player? It would make more sense to be a property of the game. You'll never have the case that some players are ranked and others aren't.