Changes between Version 1 and Version 2 of Ticket #3551


Ignore:
Timestamp:
Oct 27, 2015, 2:11:36 AM (4 years ago)
Author:
elexis
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #3551

    • Property Keywords patch review added; simple removed
    • Property Summary changed from Prohibit developer overlay cheats in rated games to [PATCH] Prohibit developer overlay cheats in rated games
    • Property Milestone changed from Backlog to Alpha 19
  • Ticket #3551 – Description

    v1 v2  
    1111
    1212 I.e. we should not execute developer overlay cheats in the simulation code if the game is rated.
    13 * Furthermore unadulterated clients should display a warning message stating that this user attempted to cheat.
     13* ~~Furthermore unadulterated clients should display a warning message stating that this user attempted to cheat.~~ (Not implementing the message as itself might be used to troll and blame innocent users as a malicious server.)
    1414
    1515'''Why prohibiting cheats can be done securely:'''
     
    5555 Notice the regular cheats are executed in `Cheats.js` and there we prohibit the cheat securely by checking `if (!cmpPlayer.GetCheatsEnabled())`. For those three developer overlay cheats we need to check if ratings are enabled.
    5656
    57 2. '''Show the cheat notification:''' If ratings are disabled and the cheat was attempted to be executed, we should display the notification. It must be sent similar to the chat simulation command:
     57~~2. '''Show the cheat notification:''' If ratings are disabled and the cheat was attempted to be executed, we should display the notification. It must be sent similar to the chat simulation command:
    5858{{{
    5959        "chat": function(player, cmd, data)
     
    6363        },
    6464}}}
    65  A new notification type has to be added to `g_NotificationsTypes` in `messages.js`. It should display a message box. Find examples in the code by searching for `messageBox`. (Please test if having two message boxes simultaneously causes trouble, as we might get a second one due to the resulting out-of-sync in that case).
     65 ~~A new notification type has to be added to `g_NotificationsTypes` in `messages.js`. It should display a message box. Find examples in the code by searching for `messageBox`. (Please test if having two message boxes simultaneously causes trouble, as we might get a second one due to the resulting out-of-sync in that case).