Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#3553 closed defect (fixed)

[PATCH] Prevent spamming the lobby with map-not-found warnings

Reported by: elexis Owned by: elexis
Priority: Must Have Milestone: Alpha 19
Component: UI & Simulation Keywords:
Cc: Patch:

Description

Reportedly someone has abused the following warning to trigger unlimited error messages in the lobby, rendering the gamelist unreadable:

warn(sprintf("Map '%(mapName)s' not found locally.", { "mapName": mapName }));

The malicious game must be selected for the warnings to occur, still we should fix it.

Attachments (1)

t3553_remove_unneeded_warning_v1.patch (1.0 KB ) - added by elexis 8 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 by Stan, 8 years ago

What happens If I play a custom made map ?

comment:2 by elexis, 8 years ago

The warning doesn't help preventing joining a match with a map that is not found locally, as the particular map might be chosen after joining the game, see #3554. Thus removing the warning is okay.

comment:3 by Josh, 8 years ago

Keywords: reviewed added; review removed
Owner: set to elexis

Solution is fine and only removes strings so it can be included with A19.

comment:4 by JoshuaJB, 8 years ago

Resolution: fixed
Status: newclosed

In 17151:

Fix #3553 by removing a superfluous warning. Patch by elexis.

comment:5 by Josh, 8 years ago

Keywords: patch reviewed removed

Thanks for the patch.

Note: See TracTickets for help on using tickets.