Opened 2 years ago

Closed 20 months ago

Last modified 20 months ago

#3561 closed defect (fixed)

Summary screen - team totals wrong

Reported by: elexis Owned by: Imarok
Priority: Should Have Milestone: Alpha 21
Component: UI & Simulation Keywords:
Cc: Patch:

Description

If you have match with a lot of trade, you will see that the value of the team barter efficiency can become bigger than 100%. The percent-values are actually added instead of averaged.

For example if there is a team with two players and they both have 50% barter efficiency, then the team value should display 50% too instead of 100%, which is quite misleading.

Attachments (1)

t3561_fix_summary_screen_meh_WIP_v0.1.patch (5.9 KB) - added by elexis 2 years ago.
Not finished, but addresses most of the issues partially.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 2 years ago by elexis

Summary: Summary screen - team barter efficiency is summed up instead of averagedSummary screen - team totals wrong

There are actually multiple issues here:

  1. The team percentage values are summed up instead of averaged (not only barter efficiency)
  2. Having infinite kill death ratio is not correct when having lost 0 units. Until we lost a unit, we don't know if the resulting value be close to 0 or close to infinity. It should display "-" instead. The team-total-value needs to take this into account correctly.

Feminization and vegetarian ratio, "barter efficiency" have the same problem. They display "0" instead of infinity.

(We decided to keep the infinity peculiarity)

  1. Map-exploration total is completely wrong (35% + 36% = 56%?) (not wrong as areas explored by both players are not taken into account twice)
  1. Kill-death-ratio team-score is identical to the score of the last player of that team, no sum, no average
Last edited 20 months ago by elexis (previous) (diff)

Changed 2 years ago by elexis

Not finished, but addresses most of the issues partially.

comment:2 Changed 2 years ago by stanislas69

refs #3150

comment:3 in reply to:  1 Changed 2 years ago by leper

Replying to elexis:

  1. Map-exploration total is completely wrong (35% + 36% = 56%?)

See #3150 as pointed out by Stan.

comment:4 Changed 2 years ago by elexis

Milestone: Alpha 19Backlog

comment:5 Changed 20 months ago by Imarok

what is missing in this patch?

comment:6 Changed 20 months ago by Imarok

Owner: set to Imarok

comment:7 Changed 20 months ago by Imarok

Cc: jon12@… added

comment:8 Changed 20 months ago by Imarok

Cc: jon12@… removed

comment:9 in reply to:  5 Changed 20 months ago by Itms

Replying to Imarok:

what is missing in this patch?

I'm not sure things are missing, it's just that it was a hacky patch that tried to fix issues that weren't issues :p (for instance the exploration total)

The patch is also clearly outdated. If you want to work on the issue I'd suggest to write a brand new patch (you can take some inspiration from elexis' one of course).

comment:10 Changed 20 months ago by Itms

Resolution: fixed
Status: newclosed

In 18026:

Fixes the handling of teams in the summary screen, along with some cleanup. Patch by Imarok, fixes #3150, #3561.

comment:11 Changed 20 months ago by Itms

Keywords: simple removed
Milestone: BacklogAlpha 21
Note: See TracTickets for help on using tickets.