Summary screen - team totals wrong

[elexis]

If you have match with a lot of trade, you will see that the value of the team barter efficiency can become bigger than 100%. The percent-values are actually added instead of averaged.

For example if there is a team with two players and they both have 50% barter efficiency, then the team value should display 50% too instead of 100%, which is quite misleading.

[elexis]

There are actually multiple issues here:

1. All of the team percentage values are summed up instead of averaged (not only barter efficiency)
2. Having infinite kill death ratio is not correct when having lost 0 units. Until we lost a unit, we don't know if the resulting value be close to 0 or close to infinity. It should display "-" instead. The team-total-value needs to take this into account correctly.

Feminization and vegetarian ratio, "barter efficiency" have the same problem. They display "0" instead of infinity.

3. Map-exploration total is completely wrong (35% + 36% = 56%?)

• Notice you have to play a match with locked-teams in order to show up the teams score.
• Only the market and miscellaneous tab have percent values.

4. Kill-death-ratio team-score is identical to the score of the last player of that team, no sum, no average

[elexis]

Not finished, but addresses most of the issues partially.

[Stan]

refs #3150

[leper]

Replying to elexis:

3. Map-exploration total is completely wrong (35% + 36% = 56%?)

See #3150 as pointed out by Stan.

[Imarok]

what is missing in this patch?

[Itms]

Replying to Imarok:

what is missing in this patch?

I'm not sure things are missing, it's just that it was a hacky patch that tried to fix issues that weren't issues :p (for instance the exploration total)

The patch is also clearly outdated. If you want to work on the issue I'd suggest to write a brand new patch (you can take some inspiration from elexis' one of course).

[Itms]

In 18026:

Fixes the handling of teams in the summary screen, along with some cleanup. Patch by Imarok, fixes #3150, #3561.