Opened 8 years ago

Closed 4 years ago

#3589 closed defect (fixed)

[PATCH] Tiny errors in UnitAI.js

Reported by: False Vision Owned by:
Priority: Nice to Have Milestone: Alpha 24
Component: Simulation Keywords:
Cc: Patch:

Description

Please see the patch i have attached.

Attachments (1)

UnitAI.patch​ (2.2 KB ) - added by False Vision 8 years ago.

Download all attachments as: .zip

Change History (12)

by False Vision, 8 years ago

Attachment: UnitAI.patch​ added

comment:1 by False Vision, 8 years ago

Component: Core engine → UI & Simulation
Priority: Should Have → Must Have

comment:2 by Stan, 8 years ago

Keywords: patch review added
Milestone: Backlog → Alpha 20
Owner: set to False Vision
Summary: Tiny errors in UnitAI.js → [PATCH] Tiny errors in UnitAI.js

Please read ​http://trac.wildfiregames.com/wiki/SubmittingPatches for submitting patches. I fixed the ticket for you :)

You can also accept the task so it's assigned to you

Last edited 8 years ago by Stan (previous) (diff)

comment:3 by False Vision, 8 years ago

Sorry for missing the keywords i am new here. And i don't know how to accept a task.

comment:4 by Stan, 8 years ago

Just click on modify ticket, and click accept radio box.

comment:5 by False Vision, 8 years ago

Status: new → assigned

comment:6 by mimo, 8 years ago

Keywords: review removed
Priority: Must Have → Nice to Have

That not an error, but a wanted feature. You may notice that the lines you've changed apply to formation, and that all the functions that you've changed make a call to Attack.GetRange. The trick is that entities use the standard Attack.GetRange which has the attackType as argument, while formations uses FormationAttack.GetRange which has the target as argument. So this ticket and the patch are invalid, but still it may be useful to add a comment in the code describing that.

comment:7 by False Vision, 8 years ago

FormationAttack.GetRange does not take two arguments neither. JS is loose enough to ignore the extra parameter passesd to the function and we are already passing two arguments which the extra one is of type uint. Why not passing an string and make the rest of components happy ?

comment:8 by elexis, 8 years ago

Milestone: Alpha 20 → Backlog

Backlogging due to lack of progress.

comment:9 by Stan, 7 years ago

Owner: False Vision removed
Status: assigned → new

Why not passing an string and make the rest of components happy ?

Somebody should answer this.

comment:10 by Imarok, 5 years ago

Component: UI & Simulation → Simulation

Move tickets to Simulation as UI & Simulation got some sub components.

comment:11 by Freagarach, 4 years ago

Keywords: patch removed
Milestone: Backlog → Alpha 24
Resolution: → fixed
Status: new → closed

Fixed by r23571.

Note: See TracTickets for help on using tickets.