Changes between Version 1 and Version 2 of Ticket #3610, comment 24


Ignore:
Timestamp:
Aug 11, 2016, 6:18:16 PM (8 years ago)
Author:
fatherbushido

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #3610, comment 24

    v1 v2  
    11Thank you for the update of the patch, that sounds very good, i will do (i hope tommorow) a (last) review of it ; if it's ok we will put it in the review queue.
    2 
    3 In progress review :
    4 
    5 AttackDetection
    6 
    7 For the first part of AttackDetection, i would suggest:
    8 {{{
    9         let cmpPlayer = Engine.QueryInterface(this.entity, IID_Player);
    10         if (!cmpPlayer)
    11                 return;
    12         let playerID = cmpPlayer.GetPlayerID()
    13         var cmpTargetPlayer = QueryOwnerInterface(target);
    14         if (!cmpTargetPlayer)
    15                 return;
    16         // Don't register attacks dealt against other players
    17         if (cmpTargetPlayer != cmpPlayer)
    18                 return;
    19 
    20         // Don't register attacks dealt by myself
    21         if (attackerOwner == playerID)
    22                 return;
    23 }}}