Changes between Initial Version and Version 1 of Ticket #3610, comment 9


Ignore:
Timestamp:
Jul 4, 2016, 3:46:26 PM (8 years ago)
Author:
fatherbushido

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #3610, comment 9

    initial v1  
    22Here are some quick remarks again
    33- (for future reviewer) the patch apply to data/, not to binary/
    4 - !AttackDetection.js L67-70 could perhaps be merged with a || or something like that
     4- !AttackDetection.js L67-70 could perhaps be merged with a `||` or something like that
    55- I understand why you need that entityOwners map but i wonder if we can in a way or another skip that ?