Changes between Version 2 and Version 3 of Ticket #3610, comment 9


Ignore:
Timestamp:
Jul 4, 2016, 8:55:23 PM (8 years ago)
Author:
fatherbushido

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #3610, comment 9

    v2 v3  
    44- !AttackDetection.js L67-70 could perhaps be merged with a `||` or something like that
    55- I understand why you need that entityOwners map but i wonder if we can in a way or another skip that ?
     6
     7Moreover, there is a more serious issue pointed out by Sanderd17 (see 2016-07-04 irc logs). The entityOwners map should be in the Init else it will not be serialized (for multiplayer and saved games).
     8
     9Then while you are at it, we can consider you are rewriting Damage, so you can remove depreciated for each loops.