Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#3611 closed defect (fixed)

[PATCH] Worker elephant can be garrisoned in houses

Reported by: elexis Owned by: mimo
Priority: Nice to Have Milestone: Alpha 20
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description

Somehow that big animal fits into those small mauryan houses. In my opinion elephants should be garrisonable in elephant stables, but surely not houses.

Refs #3135

Attachments (2)

mauryanHouse.patch (1.3 KB ) - added by mimo 8 years ago.
mauryanHouse-v2.patch (1.7 KB ) - added by mimo 8 years ago.

Download all attachments as: .zip

Change History (7)

by mimo, 8 years ago

Attachment: mauryanHouse.patch added

comment:1 by mimo, 8 years ago

Milestone: BacklogAlpha 20

Not linked to 3135, but rather to the fact that all support units can currently garrison in houses. The attached patch should fix it, but i've not really tested it. We should unsure that each time we use garrisonClasses, we support this AND through MatchesClassList.

comment:2 by Stan, 8 years ago

Keywords: review patch added
Summary: Worker elephant can be garrisoned in houses[PATCH] Worker elephant can be garrisoned in houses

comment:3 by mimo, 8 years ago

The patch i uploaded two weeks ago has the drawback that it has side effect: removing Human from the support elephant make it no more affected by health regeneration of some techs or auras (that may be something we want, but should not be linked to this ticket).

So I propose to extend the class matching functionnality (function MatchesClassList in globalscripts) to support NOT (currently we can only use AND or OR) as in the attached patch.

by mimo, 8 years ago

Attachment: mauryanHouse-v2.patch added

comment:4 by mimo, 8 years ago

Owner: set to mimo
Resolution: fixed
Status: newclosed

In 17326:

add a NOT when checking classes matching, fixes #3611

comment:5 by mimo, 8 years ago

Keywords: review removed
Note: See TracTickets for help on using tickets.