id	summary	reporter	owner	description	type	status	priority	milestone	component	resolution	keywords	cc	phab_field
3647	[PATCH] Serializationtest error when placing walls	elexis		"In #3637 we found out that `TryConstructWall()` in `Commands.js` changes the command object.

This means when doing a serializationtest, the command executed in the primary simulation is different from the one in the secondary simulation, resulting in a serializationtesterror.

To reproduce it, replay this commands.txt in serializationtest-mode: attachment:commands_reproduce_palisade_oos.txt:ticket:3637

In a multiplayergame, the commands are first sent to the server, then they are executed on all machines identically. So it's basically a '''false positive for OOS'''.

To fix it, we just need to clone the commands for the secondary simulation before the primary simulation changes them.

[[Image(http://trac.wildfiregames.com/raw-attachment/ticket/3637/fort_builders_palisade.jpg, 300px, center)]]
"	defect	new	Must Have	Alpha 20	Core engine		patch