Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#3671 closed defect (fixed)

[PATCH] Players can't rejoin if observers rejoins prior

Reported by: elexis Owned by: elexis
Priority: Nice to Have Milestone: Alpha 20
Component: Network Keywords: patch
Cc: Patch:


If MAX_CLIENTS are connected to the server, no further joins are possible. So if a player disconnects from a full server and an observer rejoins, the player can't rejoin.

In a19 it can only happen with late-observer-joins enabled. On a18 it happened too because observer-late-joins were possible due to a bug.

The NetServer should always keep the required number of client slots available and only allow observer-joins in case actual "observer slots" are available.

Change History (5)

comment:1 by elexis, 5 years ago

Keywords: patch review added
Milestone: BacklogAlpha 20

comment:2 by Itms, 5 years ago

Milestone: Alpha 20Alpha 21

comment:3 by elexis, 5 years ago

Owner: set to elexis
Resolution: fixed
Status: newclosed

In 17881:

Allow hosting matches with 8 players and up to 16 observers, fixes #3254.
The host can change the number of allowed observers in running games.

Make sure that joining observers won't take the "slot" of disconnected players, fixes #3671.

Send clients a new disconnect reason "Server full" instead of letting them timeout.

comment:4 by elexis, 5 years ago

Keywords: review removed
Milestone: Alpha 21Alpha 20
Summary: Players can't rejoin if observers rejoins prior[PATCH] Players can't rejoin if observers rejoins prior

comment:5 by elexis, 4 years ago

Component: Core engineNetwork

(set component to network)

Note: See TracTickets for help on using tickets.