Opened 8 years ago

Closed 3 years ago

Last modified 3 years ago

#3676 closed defect (fixed)

[PATCH] Disable camera hotkeys while chatting

Reported by: elexis Owned by:
Priority: Nice to Have Milestone: Alpha 24
Component: UI – In-game Keywords: patch simple
Cc: Patch:

Description

If you type chat ingame and want to move the cursor before the last word, you hold the control key and press left. But if you do that, the camera rotates as this camera hotkey has the same button-combination.

Attachments (4)

t3676.patch​ (6.2 KB ) - added by Sergey Kushnirenko 8 years ago.
t3676.2.patch​ (4.9 KB ) - added by Sergey Kushnirenko 8 years ago.
t3676.3.patch​ (4.9 KB ) - added by Sergey Kushnirenko 8 years ago.
t3676.4.patch​ (6.4 KB ) - added by Sergey Kushnirenko 8 years ago.

Download all attachments as: .zip

Change History (13)

by Sergey Kushnirenko, 8 years ago

Attachment: t3676.patch​ added

comment:1 by Sergey Kushnirenko, 8 years ago

Keywords: review patch added
Milestone: Backlog → Alpha 20
Summary: Disable camera hotkeys while chatting → [PATCH] Disable camera hotkeys while chatting

by Sergey Kushnirenko, 8 years ago

Attachment: t3676.2.patch​ added

by Sergey Kushnirenko, 8 years ago

Attachment: t3676.3.patch​ added

by Sergey Kushnirenko, 8 years ago

Attachment: t3676.4.patch​ added

comment:2 by elexis, 8 years ago

Keywords: review removed

I see you want to be able to set many camera options from JS, hence you introduced CameraSetOption and the GameView functions. While this is a good idea in case these things are actually used, in my opinion it is not good to add them without usage.

Also notice there is a function SetCameraData which likely would be useless afterwards.

So either implement an actual use-case for this function or just remove them and replace with Engine.EnableCameraHotkeys which only does that.

comment:3 by Itms, 8 years ago

Milestone: Alpha 20 → Alpha 21

comment:4 by elexis, 8 years ago

Backlogging due to lack of progress.

comment:5 by elexis, 8 years ago

Milestone: Alpha 21 → Backlog

comment:6 by elexis, 8 years ago

Keywords: simple added

comment:7 by Imarok, 5 years ago

Component: UI & Simulation → In-game UI

Move tickets to In-game UI as UI & Simulation got some sub components.

comment:8 by Stan, 3 years ago

Milestone: Backlog → Alpha 24
Resolution: → fixed
Status: new → closed

Allegedly fixed in ​Phab:rP22909

comment:9 by wraitii, 3 years ago

(More like that diff is a possible candidate TBH)

Note: See TracTickets for help on using tickets.