[PATCH] Offline-hint not shown after diplomacy change

[elexis]

When a player goes offline, it will say "playername (Offline)" when you click its entities. But if there is a diplomacy change, the name will be overwritten again without the offline-hint.

Related #3253.

[elexis]

Thanks for the patch. You correctly identified the place where the bug occurs. Your patch might work, but you should not fix it in updateDiplomacy, since it is a problem with getPlayerData.

A player is online if and only if he's found in g_PlayerAssignments. So you can add the property "offline": false to the player object and set it to true in the g_PlayerAssignments loop of that function (unless I'm completely mistaken).

[elexis]

In 17760:

Don't lose the player-offline hint on diplomacy change. Patch by dalerank, fixes #3677.
Also remove the "disconnected" property which has apparently never been used since its introduction in r8525.

[elexis]

Thanks for the patch!

[elexis]

In 17774:

Don't show the offline hint for AI-assigned players, refs #3677.

[elexis]

In 17777:

Hide the offline-hint for gaia, refs #3677.
Inline some variables.

[elexis]

In 17780:

Revert approach to detect offline players without remembering disconnect messages, since it doesn't work for entities of unassigned players. Refs #3677.
Remove unused AIManager.
Inline playerData.