Lobby - Slow rating updates break rejoining

[elexis]

Since some days there are experimental lobby changes to reduce the updates that the bot sends. This definitely helps with the performance, but it has a side effect.

It takes like 2-3 seconds for the ratinglist to appear.

• If you join a game before the ratinglist is loaded, you will join under "username".
• If you join a game after the ratinglist is loaded, you will join as "username (rating)".

This means that it's sometimes impossible to rejoin games without understanding this bug.

---

Solution: Send the ratinglist / rating for the current user instantaneously and/or prohibit lobby joins before the rating is loaded.

[Josh]

It was non-optimal to include the rating in the username in the first place. It should be an independent variable. For example, I don't believe the current system allows players to rejoin lobby games by direct IP.

[leper]

Replying to Josh:

I don't believe the current system allows players to rejoin lobby games by direct IP.

It does though.

[elexis]

Backlogging due to lack of progress.

[elexis]

Still happens with #3022, just less frequently.

[scythetwirler]

Should happen even less often (if at all) with the latest optimizations to the bot.

[elexis]

Still occurs as of Alpha 21. It can be solved by the client clicking on his own user profile before joining, so it should be fixable by issuing that request on init in lobby.js, or finding some bug in XPartaMupp.py (which would require ejabberd to debug).

[Josh]

I am still of the opinion that the rating should be stored separately. Adding a rating lookup function to the C++ side would allow for that.

[elexis]

This is happening too often.

[shookees]

Games shouldn't be identified by name, especially when it is not constant