Opened 7 years ago

Last modified 6 years ago

#3739 new enhancement

[PATCH] Lobby - late-observer-join flag

Reported by: elexis Owned by:
Priority: Should Have Milestone: Backlog
Component: Multiplayer lobby Keywords: patch, beta
Cc: Patch:

Description (last modified by Imarok)

The detail section of the selected game in the lobby should display whether late-observer-joins are allowed.

Additionally, a dialog should be added that asks the user if he actually wants to join the game as observer (preventing people from accidentally joining). The dialog should be skipped in case a the user is a rejoining player (i.e. lobby-username is in the playerlist of the selected game). (Done in r17845)

Attachments (1)

lobby_ask_observer_join_v1.patch (3.8 KB ) - added by elexis 7 years ago.

Download all attachments as: .zip

Change History (9)

by elexis, 7 years ago

comment:1 by elexis, 7 years ago

Keywords: patch review added
Milestone: BacklogAlpha 20
Priority: Nice to HaveShould Have
Summary: Lobby - late-observer-join flag[PATCH] Lobby - late-observer-join flag

The patch doesn't implement the observer-latejoin flag, but asks the user whether he wants to join as observer (in case the game already started and if he/she isn't a rejoining player).

This is quite important to prevent unwanted joins and the lag they cause.

The line let username = g_UserRating ? g_Username + " (" + g_UserRating + ")" : g_Username; is also contained in gamesetup_mp.js, but I'm not sure if a shared function would help much (in particular since this part must be changed at some point anyway, since the rating shouldn't be part of the username).

comment:2 by elexis, 7 years ago

In 17845:

To avoid unintentional joins, ask lobby users if they want to late-join the game as an observer before attempting to do so. Refs #3739.
Add selectedGame() to simplify some checks.
Add linebreaks to hostGame().

comment:3 by elexis, 7 years ago

Keywords: review removed

Thanks Itms for reviewing this.

Now only the first part of the ticket is remaining (implementation of the flag).

comment:4 by Itms, 7 years ago

Milestone: Alpha 20Alpha 21

comment:5 by elexis, 7 years ago

Milestone: Alpha 21Backlog

Not going to change the lobbybot until #3022 and configuring my local ejabberd correctly.

comment:6 by scythetwirler, 6 years ago

Keywords: beta added

comment:7 by Imarok, 6 years ago

Description: modified (diff)
Last edited 6 years ago by Imarok (previous) (diff)

comment:8 by Imarok, 6 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.