[PATCH] Lobby - late-observer-join flag

[elexis]

The detail section of the selected game in the lobby should display whether late-observer-joins are allowed.

Additionally, a dialog should be added that asks the user if he actually wants to join the game as observer (preventing people from accidentally joining). The dialog should be skipped in case a the user is a rejoining player (i.e. lobby-username is in the playerlist of the selected game). (Done in r17845)

[elexis]

The patch doesn't implement the observer-latejoin flag, but asks the user whether he wants to join as observer (in case the game already started and if he/she isn't a rejoining player).

This is quite important to prevent unwanted joins and the lag they cause.

The line let username = g_UserRating ? g_Username + " (" + g_UserRating + ")" : g_Username; is also contained in gamesetup_mp.js, but I'm not sure if a shared function would help much (in particular since this part must be changed at some point anyway, since the rating shouldn't be part of the username).

[elexis]

In 17845:

To avoid unintentional joins, ask lobby users if they want to late-join the game as an observer before attempting to do so. Refs #3739.
Add selectedGame() to simplify some checks.
Add linebreaks to hostGame().

[elexis]

Thanks Itms for reviewing this.

Now only the first part of the ticket is remaining (implementation of the flag).

[elexis]

Not going to change the lobbybot until #3022 and configuring my local ejabberd correctly.

[Imarok]

Implemented in r17845