Changes between Initial Version and Version 1 of Ticket #3742, comment 5


Ignore:
Timestamp:
Apr 17, 2016, 2:08:19 PM (8 years ago)
Author:
Imarok

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #3742, comment 5

    initial v1  
    22> * Are you sure it is okay to set the indices on `init` _before_ `loadReplays` and `displayReplayList`?
    33You mean setting {{{Engine.GetGUIObjectByName("dateTimeFilter").selected = data.replayMenuData.selectedFilters.date; }}} etc in init?
    4 That is sure as these values are set in the xml, which is loaded before the js
    5 
     4That is ok as these values are set in the xml, which is loaded before the js
     5 
    66> * It were better if you don't store the selection index, as at least `dateTimeFilter`, `mapNameFilter`, `mapSizeFilter` and `durationFilter` are generated dynamically.
    77>