[PATCH] Credits page

[Itms]

Hi, my credits page patch should be ready now.

I'm still missing some names, I'm currently contacting people, but in the meantime this is ready for review.

The translators are a specific case: there is a Python script that extracts their names from the .po files. Please comment on this matter. The output formatting is hideous, which is a shame because my script allows us to manually add people to the file. I didn't add the output in the patch (because of the poor formatting it makes a huge file), but you can test the script and see how it works.

This script might have to be added to the maintenance tasks script, but I can't really test .sh scripts here.

Finally, when I commit this I propose to make a change to SubmittingPatches so that new contributors add a change to the programming.json file. That way they can choose themselves how to be credited and this makes things easier. Do you agree with the proposal?

[Lionkanzen]

No requieres autobuild?

[Itms]

No, you don't need to build (but unless you run the python scripts there won't be anyone in the Translators list)

[fabio]

Would be possible to avoid the use of the phyton script reading the translator names directly from the .po files through some js code?

[Lionkanzen]

Ok , works fine, and is beatuful page.

[leper]

At least the programmers list has a few "nick": "" or "name": "" entries which should probably be removed.

For the python script I guess it would be better to make that part of the release process instead. (So there is no need to duplicate the language list)

Not sure if it would make sense to read the po files from js.

JS code looks good, but note a few of my comments regarding musicians, used libraries, and used source files (eg CC-BY, CC-BY-SA which would fit in here nicely).

[Itms]

I just don't know about not using a python script: that sounds like a good idea to me mods-wise but we won't be able to manually add elements, unless we hardcode them in the js file. And I don't know how to regex in js, so there's that :)

The empty nicks/names are just a personal remainder, I'll remove them when I finish going through sending emails to people. (see also the "Foo - " in the forum topic, they should be in sync)

Could you list (by PM if you want) the missing things so I add them? I don't really know where to find those pieces of information and I'm likely to forget things.

[Itms]

I managed to get the email addresses of everyone missing. I will be away the upcoming week, when I come back I'll take a look at the answers I got and will look into committing.

[Itms]

In 17830:

New in-game Credits page, fixes #3744.

[elexis]

In 18745:

Add click button sound to the gamesetup icon buttons and credits page. Patch by Vladislav, fixes #4222, refs #3805, #3744.

[elexis]

In 22966:

Fix top panel being hidden during pause mode following rP22957 / D2292 reported by Freagarach, ValihrAnt, Krinkle et al.

Remove the false misleading default.cfg z value that is always overwritten by CGUI::Xeromyces_ReadObject, both introduced in rP141.
Remove multiline property since its redundant with the default C++ boolean, making the default style more agnostic of final GUI Object classes.

Close advanced locale dialog correctly upon cancel following rP22676 / D1684.
Don't switch the background image when closing the credits dialog following rP17830, refs #3744.