Changes between Initial Version and Version 1 of Ticket #3785, comment 12


Ignore:
Timestamp:
Dec 8, 2016, 2:55:30 AM (7 years ago)
Author:
elexis

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #3785, comment 12

    initial v1  
    5353
    5454Agreeing with the compiler that every statement should be on an individual line.
    55 I subjectively prefer the `x = std::max(x, y)` pattern, but be careful in case you rearrange. You could even use an initializer list: `std::max({x, y, z})`.
     55I subjectively prefer the `x = std::max(x, y)` pattern, but be careful in case you rearrange (it also supports the initializer list `std::max({x, y, z})` though you can't use that here by the looks of things).
     56
     57------
     58
     59Re Stan: Removing code duplication in that hunk doesn't seem effective due to the slight differences in those lines and cpp being less flexible than JS.