Opened 22 months ago

Closed 20 months ago

Last modified 6 months ago

#3786 closed enhancement (fixed)

[PATCH] elliptic animal footprints

Reported by: Palaxin Owned by: sanderd17
Priority: Should Have Milestone: Alpha 21
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description (last modified by Palaxin)

Nearly all animals currently have circle footprints which do not represent their bodyshape nicely. Attached is a patch which is aimed to make footprints fit better to their owners and to enhance consistency. Have a look at the screenshot for illustration. The changes (patch version 3) are:

  • footprint resize for all land animals: length/width = 2
  • footprint resize for sharks and whales: length/width = 4 (same as triremes)
  • line thickness adjustments for fish, shark, rhino, giraffe, walrus, camel and crocodile
  • adjustments for some absurd footprint height values
  • removal of a commented out section from the peacock template which has been existing since his introduction 4 years ago at r11254
  • consistent use of integers for attack values (replaced some ".0"-floats)
  • whitespace fixes: spaces instead of tabs, added a missing newline at file end

This is the first patch of #3778, which will be split into several parts.

http://trac.wildfiregames.com/raw-attachment/ticket/3786/animal-footprints.jpg

Attachments (4)

3786_v1.patch (33.7 KB) - added by Palaxin 22 months ago.
animal-footprints.jpg (401.4 KB) - added by Palaxin 22 months ago.
3786_v2.patch (30.5 KB) - added by Palaxin 20 months ago.
fixed paths and keep fish footprint size (line thickness adjusted to other animals though)
3786_v3.patch (31.6 KB) - added by Palaxin 20 months ago.
now paths start with "binaries/data/..."

Download all attachments as: .zip

Change History (20)

Changed 22 months ago by Palaxin

Attachment: 3786_v1.patch added

Changed 22 months ago by Palaxin

Attachment: animal-footprints.jpg added

comment:1 Changed 22 months ago by Palaxin

Description: modified (diff)

comment:2 Changed 22 months ago by Palaxin

questions

  • Is the huge size of the fish footprint intended to better support multiple gatherers?
  • Is the height value of the footprints currently of any use? If not, are there any plans?
Last edited 22 months ago by Palaxin (previous) (diff)

comment:3 Changed 22 months ago by Palaxin

Description: modified (diff)

comment:4 Changed 22 months ago by Palaxin

Description: modified (diff)

comment:5 Changed 22 months ago by Palaxin

Description: modified (diff)

comment:6 Changed 21 months ago by Itms

Milestone: Alpha 20Alpha 21

comment:7 Changed 20 months ago by sanderd17

I guess the height of the footprint isn't used anymore. But I think it was used previously to determined the selection shape. And I think fish footprints were made so they're easier to find (and I think it's best to keep that size).

The patch looks good, but is annoying to apply now. Could you please create the patch so "trunk" is the root directory (and thus all paths start like "binaries/data/...").

Thanks.

Last edited 20 months ago by sanderd17 (previous) (diff)

Changed 20 months ago by Palaxin

Attachment: 3786_v2.patch added

fixed paths and keep fish footprint size (line thickness adjusted to other animals though)

Changed 20 months ago by Palaxin

Attachment: 3786_v3.patch added

now paths start with "binaries/data/..."

comment:8 Changed 20 months ago by Palaxin

sanderd17, thanks for the information :)

At first I made the paths like scythetwirler told me once.

comment:9 Changed 20 months ago by sanderd17

Well, trunk is the root of the repo (the things next to it are different repos). So scythetwirler is correct, but I can see it causing confusion.

The problem with including the name "trunk" in the diffs is that it doesn't get the same name for everyone. Like I chose to checkout SVN in the "0ad" directory, so my paths are "0ad/binaries/data/...", which meant I couldn't apply the patch without some annoying editing to it.

comment:10 Changed 20 months ago by sanderd17

Owner: set to sanderd17
Resolution: fixed
Status: newclosed

In 18014:

Improve selection rings for animals. Patch by Palaxin. Fixes #3786

comment:11 Changed 20 months ago by sanderd17

Keywords: review removed

comment:12 Changed 20 months ago by Palaxin

thanks for the commit and the explanations, now I understand :)

comment:13 Changed 20 months ago by elexis

Description: modified (diff)

comment:14 Changed 20 months ago by Palaxin

Description: modified (diff)

comment:15 Changed 20 months ago by fabio

Not strictly related to this change, but dead sheeps fall apart a bit from their selection ring. Not a big issue...

comment:16 Changed 6 months ago by elexis

In 19723:

Reduce rabbit health from 100HP to 10HP to make them more realistically huntable and have them consistent with chicken (5HP).
Increase footprint slightly for both artistic and gameplay reasons.

Differential Revision: https://code.wildfiregames.com/D562
Patch By: borg-
Refs #3786, D540

Note: See TracTickets for help on using tickets.