#3786 closed enhancement (fixed)
[PATCH] elliptic animal footprints
Reported by: | Palaxin | Owned by: | sanderd17 |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 21 |
Component: | UI & Simulation | Keywords: | patch |
Cc: | Patch: |
Description (last modified by )
Nearly all animals currently have circle footprints which do not represent their bodyshape nicely. Attached is a patch which is aimed to make footprints fit better to their owners and to enhance consistency. Have a look at the screenshot for illustration. The changes (patch version 3) are:
- footprint resize for all land animals: length/width = 2
- footprint resize for sharks and whales: length/width = 4 (same as triremes)
- line thickness adjustments for fish, shark, rhino, giraffe, walrus, camel and crocodile
- adjustments for some absurd footprint height values
- removal of a commented out section from the peacock template which has been existing since his introduction 4 years ago at r11254
- consistent use of integers for attack values (replaced some ".0"-floats)
- whitespace fixes: spaces instead of tabs, added a missing newline at file end
This is the first patch of #3778, which will be split into several parts.
Attachments (4)
Change History (20)
by , 8 years ago
Attachment: | 3786_v1.patch added |
---|
by , 8 years ago
Attachment: | animal-footprints.jpg added |
---|
comment:1 by , 8 years ago
Description: | modified (diff) |
---|
comment:3 by , 8 years ago
Description: | modified (diff) |
---|
comment:4 by , 8 years ago
Description: | modified (diff) |
---|
comment:5 by , 8 years ago
Description: | modified (diff) |
---|
comment:6 by , 8 years ago
Milestone: | Alpha 20 → Alpha 21 |
---|
comment:7 by , 8 years ago
I guess the height of the footprint isn't used anymore. But I think it was used previously to determined the selection shape. And I think fish footprints were made so they're easier to find (and I think it's best to keep that size).
The patch looks good, but is annoying to apply now. Could you please create the patch so "trunk" is the root directory (and thus all paths start like "binaries/data/...").
Thanks.
by , 8 years ago
Attachment: | 3786_v2.patch added |
---|
fixed paths and keep fish footprint size (line thickness adjusted to other animals though)
comment:8 by , 8 years ago
sanderd17, thanks for the information :)
At first I made the paths like scythetwirler told me once.
comment:9 by , 8 years ago
Well, trunk is the root of the repo (the things next to it are different repos). So scythetwirler is correct, but I can see it causing confusion.
The problem with including the name "trunk" in the diffs is that it doesn't get the same name for everyone. Like I chose to checkout SVN in the "0ad" directory, so my paths are "0ad/binaries/data/...", which meant I couldn't apply the patch without some annoying editing to it.
comment:11 by , 8 years ago
Keywords: | review removed |
---|
comment:13 by , 8 years ago
Description: | modified (diff) |
---|
comment:14 by , 8 years ago
Description: | modified (diff) |
---|
comment:15 by , 8 years ago
Not strictly related to this change, but dead sheeps fall apart a bit from their selection ring. Not a big issue...
May be discussed: