[PATCH] elliptic animal footprints

[Palaxin]

Nearly all animals currently have circle footprints which do not represent their bodyshape nicely. Attached is a patch which is aimed to make footprints fit better to their owners and to enhance consistency. Have a look at the screenshot for illustration. The changes are:

• footprint resize for all land animals: length/width = 2
• footprint resize for sharks and whales: length/width = 4 (same as triremes)
• halving of fish footprint radius (fits the swarm size now)
• line thickness adjustments for fish, shark, rhino, giraffe, walrus, camel and crocodile
• adjustments for some absurd footprint height values
• removal of a commented out section from the peacock template which has been existing since his introduction 4 years ago at r11254
• consistent use of integers for armor values (replaced some ".0"-floats)
• whitespace fixes: spaces instead of tabs, added a missing newline at file end

This is the first patch of #3778, which will be split into several parts.

[Palaxin]

questions

• Is the huge size of the fish footprint intended to better support multiple gatherers?
• Is the height value of the footprints currently of any use? If not, are there any plans?

[sanderd17]

I guess the height of the footprint isn't used anymore. But I think it was used previously to determined the selection shape. And I think fish footprints were made so they're easier to find (and I think it's best to keep that size).

The patch looks good, but is annoying to apply now. Could you please create the patch so "trunk" is the root directory (and thus all paths start like "binaries/data/...").

Thanks.

[Palaxin]

fixed paths and keep fish footprint size (line thickness adjusted to other animals though)

[Palaxin]

now paths start with "binaries/data/..."

[Palaxin]

sanderd17, thanks for the information :)

At first I made the paths like scythetwirler ​told me once.

[sanderd17]

Well, trunk is the root of the repo (the things next to it are different repos). So scythetwirler is correct, but I can see it causing confusion.

The problem with including the name "trunk" in the diffs is that it doesn't get the same name for everyone. Like I chose to checkout SVN in the "0ad" directory, so my paths are "0ad/binaries/data/...", which meant I couldn't apply the patch without some annoying editing to it.

[sanderd17]

In 18014:

Improve selection rings for animals. Patch by Palaxin. Fixes #3786

[Palaxin]

thanks for the commit and the explanations, now I understand :)