Opened 8 years ago
Closed 8 years ago
#3788 closed enhancement (wontfix)
Refactoring and clarifies gui subsystem source code
Reported by: | Sergey Kushnirenko | Owned by: | |
---|---|---|---|
Priority: | Nice to Have | Milestone: | |
Component: | Core engine | Keywords: | patch |
Cc: | Patch: |
Description
I research some items in IGUIObject class and want to suggest refactoring which can class declaration easy and more clarify.
Attachments (2)
Change History (6)
by , 8 years ago
Attachment: | gui_subsystem_code_refactoring.patch added |
---|
comment:1 by , 8 years ago
Priority: | Should Have → Nice to Have |
---|
by , 8 years ago
Attachment: | gui_subsystem_code_refactoring.2.patch added |
---|
follow-up: 3 comment:2 by , 8 years ago
comment:3 by , 8 years ago
Replying to dalerank:
Format code like GameView class
I think, it needs to add new lines between function declarations and inside of implementations.
comment:4 by , 8 years ago
Keywords: | simple review removed |
---|---|
Milestone: | Backlog |
Resolution: | → wontfix |
Status: | new → closed |
Hi, thanks for the patch but unfortunately there is no need for such a refactoring. We only use a pimpl in GameView, that's not something we'd like to have everywhere.
Here are two issues that you should pay special attention to in your future patches:
- We don't use
auto
, in order to know which type a variable is - Your cut-and-paste of Doxygen comments messed up the indentation (there is one space missing for each line)
Thanks for the work anyways, don't hesitate to ask on IRC if you don't know whether some change is wanted.
Format code like GameView class