Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#3799 closed defect (fixed)

[PATCH] Meta modifications of auras

Reported by: fatherbushido Owned by: mimo
Priority: Must Have Milestone: Alpha 20
Component: UI & Simulation Keywords: patch
Cc: Sanderd17 Patch:

Description (last modified by fatherbushido)

In Aura.js, meta modifications of auras is not yet implemented for garrisonedUnits, garrison or formation types aura. (By meta modifications we mean modifications by technology (or even auras) of aura modifications).

We can't see this defect in current simulation.

Attachments (6)

3799.diff (1.3 KB ) - added by fatherbushido 8 years ago.
/home/titi/3799.diff
uglymodsfortest.diff (3.7 KB ) - added by fatherbushido 8 years ago.
3799.2.diff (1.8 KB ) - added by fatherbushido 8 years ago.
3799.3.diff (1.2 KB ) - added by fatherbushido 8 years ago.
3799.4.diff (1.3 KB ) - added by fatherbushido 8 years ago.
3799.4.2.diff (982 bytes ) - added by fatherbushido 8 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 by fatherbushido, 8 years ago

Description: modified (diff)

comment:2 by fatherbushido, 8 years ago

Actually, it's very hard to see in the current game. The tests i use are :

  • i modify some technologies (see uglymodsfortest.diff).
  • with athenians, i garrison one slinger on a long wall. His armour gets +3.
  • applying the technology in tower Crenellations, this armour bonus must be increase. Actually, we need to unload and reload to have this effect.
  • still with athenians, i put Iphicrates in a formation. Armour of soldiers gets +1.
  • applying the technology in tower Sturdy Foundations, this armour bonus must be increase. Actually, it isn't.
  • still with athenians, i put Iphicrates in a structure. HP max get +3000 (aura2).
  • applying the technology in tower Murderhole, this HP max bonus must be increase. Actually, we need to unload and reload to have this effect.
Last edited 8 years ago by fatherbushido (previous) (diff)

by fatherbushido, 8 years ago

Attachment: 3799.diff added

/home/titi/3799.diff

by fatherbushido, 8 years ago

Attachment: uglymodsfortest.diff added

comment:3 by fatherbushido, 8 years ago

Description: modified (diff)
Keywords: review added

comment:4 by fatherbushido, 8 years ago

Summary: Meta modifications of auras[PATCH] Meta modifications of auras

by fatherbushido, 8 years ago

Attachment: 3799.2.diff added

by fatherbushido, 8 years ago

Attachment: 3799.3.diff added

by fatherbushido, 8 years ago

Attachment: 3799.4.diff added

comment:5 by fatherbushido, 8 years ago

Priority: Should HaveMust Have

by fatherbushido, 8 years ago

Attachment: 3799.4.2.diff added

comment:6 by mimo, 8 years ago

Owner: set to mimo
Resolution: fixed
Status: newclosed

In 17863:

fix modifications (by tech or aura) of garrison and formation auras, fixes #3799, patch by fatherbushido

comment:7 by mimo, 8 years ago

Keywords: review removed

Thanks for the patch

Note: See TracTickets for help on using tickets.