Opened 3 years ago

Last modified 15 months ago

#3814 assigned enhancement

[PATCH] Cinematic camera improvemets

Reported by: fabio Owned by: Vladislav Belov
Priority: Should Have Milestone: Backlog
Component: Core engine Keywords: patch
Cc: Patch:

Description (last modified by elexis)

Some suggestions splitted from #3301.

  • mouse cursor should be disabled during cutscenes; also if you are selecting units when cutscene start you see the selection rectangle during all the cutscene (preliminary patch available in #3301);
  • if I run at double speed (more options setting) the cutscene play at 1x speed but terminates before (probably at half time); possible solution is to reset speed to 1x when on cutscene mode;
  • add at least a working demo;

Possible future ideas:

  • add cutscene on every game ending (either win or loose):
    • 1) simulation stops;
    • 2) human units change to cheering animation;
    • 3) camera moves over winning soldiers or other interesting hotspots until;
    • 4) player press the button to continue or quit;
  • add cutscene on game start:
    • 1) simulation stops;
    • 2) camera moves from the CC up to the traditional camera starting position using some path (a spiral around the CC);
    • 3) simulation start again;
  • show an introductory cutscene on game start, eventually only on the first run (and ability to show it again through menu).

Attachments (7)

Cinema_Demo.zip (122.4 KB) - added by sanderd17 3 years ago.
Demo map
cinematic_camera_spline_clear.patch (3.0 KB) - added by Vladislav Belov 2 years ago.
Adds spline description, fix target spline building
cinematic_camera_spline_clear.2.patch (2.3 KB) - added by Vladislav Belov 2 years ago.
cinematic_camera_cleanup_1.patch (7.2 KB) - added by Vladislav Belov 2 years ago.
cinematic_camera_cleanup_2.patch (7.7 KB) - added by Vladislav Belov 2 years ago.
cinematic_camera_cleanup_3.patch (8.9 KB) - added by Vladislav Belov 2 years ago.
Cinema_Demo.2.zip (130.9 KB) - added by Vladislav Belov 18 months ago.

Download all attachments as: .zip

Change History (27)

Changed 3 years ago by sanderd17

Attachment: Cinema_Demo.zip added

Demo map

comment:1 Changed 3 years ago by sanderd17

I've included a working demo map above. The map is based completely on Vladislav's work, I only added some commands for different units, so the map doesn't look static (and you see the game is actually running).

Changed 2 years ago by Vladislav Belov

Adds spline description, fix target spline building

comment:2 Changed 2 years ago by Vladislav Belov

Keywords: patch review added
Owner: set to Vladislav Belov
Priority: Nice to HaveShould Have
Status: newassigned
Summary: Cinematic camera improvemets[PATCH] Cinematic camera improvemets

comment:3 Changed 2 years ago by Vladislav Belov

Milestone: BacklogAlpha 21

Changed 2 years ago by Vladislav Belov

comment:4 Changed 2 years ago by sanderd17

In 17975:

Interpolate cinematic camera rotation + allow more points in cinematic path + add comments. Patch by Vladislav. Refs #3814

comment:5 Changed 2 years ago by elexis

Keywords: review removed

comment:6 Changed 2 years ago by Vladislav Belov

Keywords: review added

Changed 2 years ago by Vladislav Belov

comment:7 Changed 2 years ago by sanderd17

In 18000:

Move some methods out of the headers. Patch by Vladislav. Refs #3814

comment:8 Changed 2 years ago by sanderd17

Keywords: review removed

Forgot to remove the review tag ...

Changed 2 years ago by Vladislav Belov

comment:9 Changed 2 years ago by Vladislav Belov

Keywords: review added
  • fix elexis issue (couldn't play a path twice, CCmpCinemaManager.cpp:198 CurrentPathElapsedTime? wasn't be cleared, so after start a path will be already ended)
  • remove duplication of the node drawing code (CCinemaPath.cpp:174-191, using for debugging and atlas), instead of hardcoded target spline rendering
  • fix delay issue (when camera stays few seconds after playing), (CCinemaPath.cpp:359, CCmpCinemaManager.cpp:202, earlier path won't be popped from queue immediately after end, pop back from queue xor cinema end)
  • fix serializing (target nodes missed, CCmpCinemaManager.cpp:107, were usual position nodes instead of target nodes)
Last edited 2 years ago by Vladislav Belov (previous) (diff)

comment:10 Changed 2 years ago by sanderd17

In 18041:

Cleanup cinema code. Fix some issues with resetting of times. Patch by Vladislav. Refs #3814

comment:11 Changed 2 years ago by sanderd17

Keywords: review removed

Changed 2 years ago by Vladislav Belov

comment:12 Changed 2 years ago by Vladislav Belov

Keywords: review added
  • fix issue with multiple target nodes between two position nodes (i.e. you wasn't able to put node with only target param)
  • cinemapath could change any camera (passing by param)
  • improve reading/writing path

comment:13 Changed 2 years ago by elexis

Milestone: Alpha 21Alpha 22

Feature freeze in 2 days.

comment:14 Changed 22 months ago by elexis

In 18992:

Play cinematic paths on arbitrary cameras to prepare previews of the camera frustum in atlas. Patch by Vladislav, refs #3814.

comment:15 Changed 22 months ago by elexis

Milestone: Alpha 22Work In Progress

Moving to the new WIP milestone.

comment:16 Changed 20 months ago by elexis

Keywords: review removed

First part of the patch was committed, see above, remaining patch at https://code.wildfiregames.com/D124

comment:17 Changed 18 months ago by elexis

In 19317:

Allow Cinematic Path nodes that only specify a camera position or direction and group them by deltatime.
Remove the support of saving the rotation of camera position nodes, because that should be rewritten to use a custom spline.

Patch By: Vladislav
Differential Revision: https://code.wildfiregames.com/D124
Refs #3814

Changed 18 months ago by Vladislav Belov

Attachment: Cinema_Demo.2.zip added

comment:18 Changed 18 months ago by elexis

In 19319:

Cinematic path demo map

Patch By: Vladislav
Refs #3301 #3814

comment:19 Changed 18 months ago by elexis

In 19422:

Support cinematic path creation from trigger scripts.

Differential Revision: https://code.wildfiregames.com/D317
Patch By: Vladislav
Refs #3814

comment:20 Changed 15 months ago by elexis

Description: modified (diff)
Milestone: Work In ProgressBacklog
Note: See TracTickets for help on using tickets.