#3817 closed defect (fixed)
[PATCH] Missing rounding in tooltip
Reported by: | fatherbushido | Owned by: | elexis |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 20 |
Component: | UI & Simulation | Keywords: | patch |
Cc: | Patch: |
Description
when using relative template, armour tooltip has many decimals. Armour tooltip may be round to one 1 decimal like attack tooltip.
Attachments (1)
Change History (6)
by , 8 years ago
Attachment: | tooltip.diff added |
---|
comment:1 by , 8 years ago
Priority: | Must Have → Should Have |
---|
comment:2 by , 8 years ago
comment:5 by , 8 years ago
Keywords: | review removed |
---|
Thanks for the patch.
Mostly committing this because
- in case of rational numbers, we need to show at most 0 or 1 digits
- all the other places use ToFixed(1)
- the digit after the comma can make a difference of some percent, so having one decimal is legit for the folks computing equations
Note:
See TracTickets
for help on using tickets.
Can you provide a sample patch to produce the rounding error?
Not sure if we need one place after the comma. If we do,
toFixed
seems like the right function to use, if not, we should useMath.round
.