Changes between Initial Version and Version 1 of Ticket #3841, comment 3


Ignore:
Timestamp:
Jul 8, 2016, 2:36:32 PM (2 years ago)
Author:
fatherbushido
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #3841, comment 3

    initial v1  
    1 Don't forget to make it coherent with the test in simulation/components/tests/test_GuiInterface.js
    2 (it will be broken, as you add "hasSharedLos" to !GuiInterface).
     1- i didn't noticed bugs while doing a quick test,
     2- Don't forget to make it coherent with the test in simulation/components/tests/test_GuiInterface.js (it will be broken, as you add "hasSharedLos" to !GuiInterface).
     3- as noticed by elexis, cmpTechnologyManager && cmpTechnologyManager.!IsTechnologyResearched("unlock_shared_los"), is a bit ugly in !GuiInterface, perhaps you may move it to Player to be more coherent with the actual code.