Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#3884 closed defect (fixed)

[PATCH] Add current OS X version to build-osx-bundle.sh

Reported by: jurgemaister Owned by: Itms
Priority: Must Have Milestone: Alpha 21
Component: Build & Packages Keywords: osx patch
Cc: historic_bruno, trompetin17, wraitii Patch:

Description

Currently, the script has the OS X version 10.10 hard coded into the SYSROOT path, but the current version of OS X is 10.11. I changed this to use the version running on the user's computer.

Attachments (1)

build-osx-bundle-sh.diff​ (1.0 KB ) - added by jurgemaister 8 years ago.

Download all attachments as: .zip

Change History (5)

by jurgemaister, 8 years ago

Attachment: build-osx-bundle-sh.diff​ added

comment:1 by elexis, 8 years ago

Keywords: patch review added

comment:2 by Itms, 8 years ago

Cc: historic_bruno trompetin17 wraitii added
Keywords: rfc added; review removed

Sorry for having this patch pending, the people who can test that on OSX have not been notified :(

Can someone apply the patch and try to build a release bundle? At the very least the change will be tested when the next version is packaged.

Thanks for the patch!

comment:3 by Itms, 8 years ago

Owner: set to Itms
Resolution: → fixed
Status: new → closed

In 18726:

Use the current OS X version instead of a hardcoded value in the path to the OSX development tools, when building the OSX bundle.

Patch by jurgemaister, plus some little fixes, fixes #3884.
Tested on OSX 10.11.

comment:4 by Itms, 8 years ago

Keywords: rfc removed

Thanks for the patch. I finally went ahead and tested it on a VM.

Note: See TracTickets for help on using tickets.