#3887 closed defect (fixed)
[PATCH] Put auras back into structree tooltips.
| Reported by: | s0600204 | Owned by: | s0600204 |
|---|---|---|---|
| Priority: | Should Have | Milestone: | Alpha 21 |
| Component: | UI & Simulation | Keywords: | patch |
| Cc: | Patch: |
Description
With the recent relocation of auras from being embedded in XML to separate JSON files, said auras have stopped showing up in the structree.
The attached patch resolves that.
Attachments (3)
Change History (8)
by , 8 years ago
| Attachment: | put_auras_back_in_structree.patch added |
|---|
by , 8 years ago
| Attachment: | putAurasBack_v2.patch added |
|---|
comment:1 by , 8 years ago
| Keywords: | review removed |
|---|
Did you test your patch? I get the following error:
ERROR: JavaScript error: gui/structree/helper.js line 13 ReferenceError: template is not defined loadTemplate@gui/structree/helper.js:13:1 loadUnit@gui/structree/load.js:42:6 selectCiv@gui/structree/structree.js:81:5 __eventhandler38 (selectionchange)@civSelection selectionchange:0:1 init@gui/structree/structree.js:38:3 __eventhandler8 (press)@menuStrucTreeButton press:2:8 ERROR: GUI page 'page_structree.xml': Failed to call init() function
by , 8 years ago
| Attachment: | putAurasBack_v3.patch added |
|---|
Yes, I'm fairly sure I did. However... fixed.
comment:2 by , 8 years ago
| Keywords: | review added |
|---|
comment:4 by , 8 years ago
| Keywords: | review removed |
|---|
Note:
See TracTickets
for help on using tickets.
Comment corrected, patch taken from more sensible root