[PATCH] Changing music gain doesn't have any effect

[Erik Johansson]

Reported by a user on Facebook, but in a quick testing on Alpha 20 I could reporoduce it. Changing the general volume gain works, but not the music gain. As far as I can tell the other gain settings work as well, but it's a bit involved to test e.g. the ambience so I'm not 100% sure about that.

[elexis]

Backlogging due to lack of progress.

[Damien PIQUET]

This problem only happens in the main menu.

=> in game, music is paused when in options menu. Music is resumed with the updated gain => in the main menu, music is playing when in options menu so it's not updated immediately.

[elexis]

Thanks for coming up with a patch! Did you try if m_CurrentTune->SetGain might be sufficient already? In my opinion it would be better to set the gain immediately rather than having to wait for one second to check the actual sound output (not a big problem though).

[Damien PIQUET]

change sound immediatly

[Damien PIQUET]

That works too, and will probably be better when volume sliders will be implemented (saw a couple todos on the js side). Attached updated patch.

[elexis]

In 18193:

Actually update the sound gain after changing the setting. Patch by dpiquet, fixes #3901.

[elexis]

Thanks for the patch, and thanks to feneur for filing a report!