Opened 20 months ago

Closed 19 months ago

Last modified 19 months ago

#3901 closed defect (fixed)

[PATCH] Changing music gain doesn't have any effect

Reported by: Erik Johansson Owned by: Damien PIQUET
Priority: Must Have Milestone: Alpha 21
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description

Reported by a user on Facebook, but in a quick testing on Alpha 20 I could reporoduce it. Changing the general volume gain works, but not the music gain. As far as I can tell the other gain settings work as well, but it's a bit involved to test e.g. the ambience so I'm not 100% sure about that.

Attachments (2)

3901.patch (463 bytes) - added by Damien PIQUET 19 months ago.
3901-2.patch (439 bytes) - added by Damien PIQUET 19 months ago.
change sound immediatly

Download all attachments as: .zip

Change History (11)

comment:1 Changed 19 months ago by elexis

Backlogging due to lack of progress.

comment:2 Changed 19 months ago by elexis

Milestone: Alpha 21Backlog

Changed 19 months ago by Damien PIQUET

Attachment: 3901.patch added

comment:3 Changed 19 months ago by Damien PIQUET

This problem only happens in the main menu.

=> in game, music is paused when in options menu. Music is resumed with the updated gain => in the main menu, music is playing when in options menu so it's not updated immediately.

comment:4 Changed 19 months ago by stanislas69

Keywords: review patch added
Milestone: BacklogAlpha 21
Summary: Changing music gain doesn't have any effect[PATCH] Changing music gain doesn't have any effect

comment:5 Changed 19 months ago by Damien PIQUET

Owner: set to Damien PIQUET

comment:6 Changed 19 months ago by elexis

Thanks for coming up with a patch! Did you try if m_CurrentTune->SetGain might be sufficient already? In my opinion it would be better to set the gain immediately rather than having to wait for one second to check the actual sound output (not a big problem though).

Changed 19 months ago by Damien PIQUET

Attachment: 3901-2.patch added

change sound immediatly

comment:7 Changed 19 months ago by Damien PIQUET

That works too, and will probably be better when volume sliders will be implemented (saw a couple todos on the js side). Attached updated patch.

comment:8 Changed 19 months ago by elexis

Resolution: fixed
Status: newclosed

In 18193:

Actually update the sound gain after changing the setting. Patch by dpiquet, fixes #3901.

comment:9 Changed 19 months ago by elexis

Keywords: review removed

Thanks for the patch, and thanks to feneur for filing a report!

Note: See TracTickets for help on using tickets.