Opened 19 months ago

Closed 18 months ago

Last modified 18 months ago

#3930 closed enhancement (fixed)

[PATCH] Modifications of Technology Resources Cost and Research Time.

Reported by: fatherbushido Owned by: sanderd17
Priority: Should Have Milestone: Alpha 21
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description (last modified by fatherbushido)

As noticed at wiki and in discussions on irc in 2012, the modifications of technology cost and research time is still TBD.

Attachments (14)

3930.diff (9.6 KB) - added by fatherbushido 19 months ago.
wip
3930.2.diff (9.3 KB) - added by fatherbushido 19 months ago.
3930.3.diff (8.2 KB) - added by fatherbushido 19 months ago.
3930.4.diff (8.2 KB) - added by fatherbushido 19 months ago.
3930.5.diff (45.0 KB) - added by fatherbushido 19 months ago.
3930.6.diff (46.6 KB) - added by fatherbushido 19 months ago.
i forgot to add the 2 auras
3930.7.diff (34.1 KB) - added by fatherbushido 19 months ago.
3930.8.diff (36.6 KB) - added by fatherbushido 18 months ago.
3930_testcaseforstructuretree.diff (671 bytes) - added by fatherbushido 18 months ago.
testcase : change the tech food cost for athenians fortress techs
3930.9.diff (34.3 KB) - added by fatherbushido 18 months ago.
(cleanup)
3930.10.diff (35.3 KB) - added by fatherbushido 18 months ago.
merge s0600204 lines
3930.11.diff (40.3 KB) - added by fatherbushido 18 months ago.
add library aura and s% structure tree updates
3930.12.diff (40.4 KB) - added by fatherbushido 18 months ago.
fix aschoka tooltip
3930.13.diff (41.8 KB) - added by fatherbushido 18 months ago.
remove productionqueue of mauryan_pilar and sele_colonade

Download all attachments as: .zip

Change History (26)

comment:1 Changed 19 months ago by fatherbushido

Description: modified (diff)

The wip patch implement that and allow range, garrison, garrisonedUnits aura to modify costs of techs. I join as example two mauryans auras (according to TBD tooltips and to design docs). The patch is still a draft but it "works" (i need to check translate stuff and Petra).

Last edited 19 months ago by fatherbushido (previous) (diff)

Changed 19 months ago by fatherbushido

Attachment: 3930.diff added

wip

Changed 19 months ago by fatherbushido

Attachment: 3930.2.diff added

Changed 19 months ago by fatherbushido

Attachment: 3930.3.diff added

comment:2 Changed 19 months ago by fatherbushido

Keywords: review added
  • patch enables modification of technology Technology/Cost/stuff (stuff can be food, wood, stone, metal, time).
  • allows local modifications by Auras
  • uses some bad names (that function in GuiInterface) and it is perhaps sometimes clumsy.
  • doesn't care of Petra.
Last edited 19 months ago by fatherbushido (previous) (diff)

Changed 19 months ago by fatherbushido

Attachment: 3930.4.diff added

comment:3 Changed 19 months ago by fatherbushido

Keywords: review removed

Changed 19 months ago by fatherbushido

Attachment: 3930.5.diff added

comment:4 Changed 19 months ago by fatherbushido

Keywords: review added

After discussions with mimo and sanderd17:

  • add a mandatory TechCostMultiplier? in ProductionQueue? schema (set to 1 by default). I checked all production queue (and even check with scenario Units demo).
  • patch enables modification of technology cost in the production queue of a building with the key TechCostMultiplier?/stuff (stuff can be food, wood, stone, metal, time).
  • Said modifications are well taken into account in the gui.
  • I joined as example two mauryans auras (according to TBD tooltips and to design docs).
  • I sorted some templates where alphabetical order was messed.

I think Petra stuff can be adressed in another ticket.

Changed 19 months ago by fatherbushido

Attachment: 3930.6.diff added

i forgot to add the 2 auras

Changed 19 months ago by fatherbushido

Attachment: 3930.7.diff added

comment:5 Changed 19 months ago by fatherbushido

Done : !

  • add a mandatory TechCostMultiplier in ProductionQueue schema (set to 1 by default). I checked all production queue (and even check with scenario Units demo).
  • patch enables modification of technology cost in the production queue of a building with the key TechCostMultiplier/stuff (stuff can be food, wood, stone, metal, time).
  • Said modifications are well taken into account in the gui.
  • I joined as example two mauryans auras and the library aura (according to TBD tooltips and to design docs).
  • Moreover if we change multipliers straightly in the template, it is well taken into account in the structure tree.

Not done :

  • I think Petra stuff can be adressed in another ticket.
Last edited 18 months ago by fatherbushido (previous) (diff)

Changed 18 months ago by fatherbushido

Attachment: 3930.8.diff added

Changed 18 months ago by fatherbushido

testcase : change the tech food cost for athenians fortress techs

Changed 18 months ago by fatherbushido

Attachment: 3930.9.diff added

(cleanup)

comment:6 Changed 18 months ago by s0600204

Might I suggest these additional changes for compatibility with the structree: http://pastebin.com/deBctCbN?

clone() to prevent multipliers displaying on other buildings using the affected techs; and making sure techCostMultipliers are used with wallsets.

(Edit: Clarified brackets in diff per elexis comments on irc)

Last edited 18 months ago by s0600204 (previous) (diff)

Changed 18 months ago by fatherbushido

Attachment: 3930.10.diff added

merge s0600204 lines

comment:7 Changed 18 months ago by s0600204

Assuming you want tech multipliers to apply to technologies researchable directly by units (see #4001), then might I propose the additional change http://pastebin.com/rjYSNzWz to get the multipliers to be taken into account for "Trainer Units" in the structree?

Last edited 18 months ago by s0600204 (previous) (diff)

Changed 18 months ago by fatherbushido

Attachment: 3930.11.diff added

add library aura and s% structure tree updates

comment:8 Changed 18 months ago by fatherbushido

thx s0600204 for the maintenance of a non yet commited patch ;-)

comment:9 Changed 18 months ago by mimo

I've created a new ticket #4003 with the needed changes for the AI, but these can be done afterwards as long as that the current changes only decrease the cost. So having a different ticket for the AI will ease the reviews.

Changed 18 months ago by fatherbushido

Attachment: 3930.12.diff added

fix aschoka tooltip

Changed 18 months ago by fatherbushido

Attachment: 3930.13.diff added

remove productionqueue of mauryan_pilar and sele_colonade

comment:10 Changed 18 months ago by sanderd17

Owner: set to sanderd17
Resolution: fixed
Status: newclosed

In 18233:

Let auras and techs modify tech cost. Patch by fatherbushido. Fixes #3930

comment:11 Changed 18 months ago by sanderd17

Keywords: review removed
Type: defectenhancement

comment:12 Changed 18 months ago by elexis

In 18248:

Unique building aura balancing, refs #3930

Owning multiple libraries and theatrons increases the aura bonus proportionally, so as to incentivize capturing.
Make the library aura more appealing by giving a 10% research time bonus.
Improve a tooltip.

Note: See TracTickets for help on using tickets.