Changes between Initial Version and Version 1 of Ticket #3934, comment 11
- Timestamp:
- Jul 7, 2016, 4:00:28 AM (8 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #3934, comment 11
initial v1 1 Review for 18494: 2 * Your patch didn't remove all references to g_CostDisplayIcons, you didn't take into account the new occurance in r18154. 3 * Better use type than c. One letter names should, if at all, only be used for integer counters in loops, not for strings. 4 * (The `totalCosts[type]` check was actually needed as a template could set the resource to 0 to disable a value of the parent template.) 5 6 Review remaining code: 1 7 * `globalscripts` should load and parse the resource types, so that the GUI can access too without having to rely on the simulation or saving that somewhere 2 8 * summary screen not updated in all places