Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#3947 closed defect (fixed)

[PATCH] Sheep are affected by auras

Reported by: elexis Owned by: sanderd17
Priority: Nice to Have Milestone: Alpha 21
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description

When selecting a hero with an attack aura, all nearby sheep will show the aura icon, which seems counterintuitive, as sheep can't attack.

Reported by Hannibal Barca.

Attachments (1)

3947.diff (10.1 KB ) - added by fatherbushido 8 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 by fatherbushido, 8 years ago

Yes they have the Unit class (son of template_unit) and many auras affects the Unit class. For most of the aura, adding Human class should fix that.

Last edited 8 years ago by fatherbushido (previous) (diff)

comment:2 by sanderd17, 8 years ago

Simple: replace the Unit class requirement in the hero aura by "Soldier".

by fatherbushido, 8 years ago

Attachment: 3947.diff added

comment:3 by fatherbushido, 8 years ago

Sanderd17 class suggestion is even simpler. (sometimes siege can perhaps be affected too) patch :

  • use more consistent classes
  • add iber monument aura description and name (from design docs)
  • fix some typos (my bad :/)

comment:4 by fatherbushido, 8 years ago

Keywords: patch review added
Milestone: BacklogAlpha 21
Summary: Sheep are affected by auras[PATCH] Sheep are affected by auras

comment:5 by sanderd17, 8 years ago

Owner: set to sanderd17
Resolution: fixed
Status: newclosed

In 18125:

Fix some auras. Patch by fatherbushido. Fixes #3947

comment:6 by sanderd17, 8 years ago

Keywords: review removed
Note: See TracTickets for help on using tickets.