Opened 8 years ago
Last modified 4 years ago
#3950 closed enhancement
Rework rating-setting — at Initial Version
Reported by: | elexis | Owned by: | |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 24 |
Component: | UI – Game setup | Keywords: | |
Cc: | fpre_O_O_O_O_O_O | Patch: |
Description
- The setting is saved in both C++ (
Engine.IsRankedGame()
) and simulation gamesettings (g_GameAttributes.settings.RatingEnabled
). Should be only one of both.
Saving it in the simulation seems kind-of wrong, since it is not used by it (yet?). Saving it in
cpp
seems to be much worse/uglier to me. That variableg_rankedGame
is only used to disable the wireframe hotkey inCGameView::HandleEvent
. Instead a global function could be introduced to check forRatingEnabled
of the gameattributes of the current client.
- The rated-game setting should be invisible in the GUI and unchecked if there are more than 2 players (since only 1v1s are rated due to ELO system in use)
- Following that, the provisional 2-player check in
reportGame()
and the replay filter can be removed
Note:
See TracTickets
for help on using tickets.