Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#3980 closed defect (fixed)

[PATCH] Remove naming inconsistencies in gamesetup

Reported by: Imarok Owned by: elexis
Priority: Should Have Milestone: Alpha 21
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description

Most options follow the pattern: foo for the control and fooText for the label. This should apply to all of them.

Attachments (5)

gamesetup_naming.patch (5.8 KB ) - added by Imarok 8 years ago.
rename mapFilterSelection, mapTypeSelection and numPlayersSelection
gamesetup_naming_v2.patch (5.8 KB ) - added by Imarok 8 years ago.
dont use the name numPlayersControl
gamesetup_naming_v3.patch (5.8 KB ) - added by Imarok 8 years ago.
gamesetup_naming_v4.patch (7.0 KB ) - added by Imarok 8 years ago.
Added some more loops
gamesetup_naming_v4.2.patch (7.0 KB ) - added by Imarok 8 years ago.
corrected typo

Download all attachments as: .zip

Change History (10)

by Imarok, 8 years ago

Attachment: gamesetup_naming.patch added

rename mapFilterSelection, mapTypeSelection and numPlayersSelection

by Imarok, 8 years ago

Attachment: gamesetup_naming_v2.patch added

dont use the name numPlayersControl

comment:1 by elexis, 8 years ago

Keywords: review removed

Due to the consistent naming of GUI objects, the hideControl calls should be done in a loop.

by Imarok, 8 years ago

Attachment: gamesetup_naming_v3.patch added

comment:2 by Imarok, 8 years ago

Keywords: review added

by Imarok, 8 years ago

Attachment: gamesetup_naming_v4.patch added

Added some more loops

by Imarok, 8 years ago

Attachment: gamesetup_naming_v4.2.patch added

corrected typo

comment:3 by elexis, 8 years ago

Owner: set to elexis
Resolution: fixed
Status: newclosed

In 18169:

Gamesetup cleanup. Patch by Imarok, fixes #3980.

Rename GUI objects to numPlayers, mapFilter and mapType for consistency.
Thus use loops to remove code duplication for hiding controls.

comment:4 by elexis, 8 years ago

Keywords: review removed

Thanks! Had been waiting long for that one actually :)

comment:5 by Imarok, 8 years ago

refs #3049

Note: See TracTickets for help on using tickets.