#4007 closed enhancement (fixed)
[PATCH] Cleanup selection panels
| Reported by: | sanderd17 | Owned by: | sanderd17 |
|---|---|---|---|
| Priority: | Must Have | Milestone: | Alpha 21 |
| Component: | UI & Simulation | Keywords: | patch |
| Cc: | elexis | Patch: |
Description
Changes in this patch:
- The loop still happens over items, but the panels now have only one functions that sets the button content. This also makes the addData function obsolete, as it now happens all in the same scope, so data can be reused even without putting it in a data object
- The entire file has been updated from var to let, which means that some closure constructions could be removed.
Attachments (3)
Change History (5)
by , 8 years ago
| Attachment: | selection_panels_cleanup.diff added |
|---|
by , 8 years ago
| Attachment: | selection_panels_cleanup.2.diff added |
|---|
by , 8 years ago
| Attachment: | selection_panels_cleanup.3.diff added |
|---|
comment:2 by , 8 years ago
| Keywords: | review removed |
|---|
Note:
See TracTickets
for help on using tickets.
Update to current SVN, revert all changes done to colour tags, implement some more remarks