Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#4007 closed enhancement (fixed)

[PATCH] Cleanup selection panels

Reported by: sanderd17 Owned by: sanderd17
Priority: Must Have Milestone: Alpha 21
Component: UI & Simulation Keywords: patch
Cc: elexis Patch:

Description

Changes in this patch:

  • The loop still happens over items, but the panels now have only one functions that sets the button content. This also makes the addData function obsolete, as it now happens all in the same scope, so data can be reused even without putting it in a data object
  • The entire file has been updated from var to let, which means that some closure constructions could be removed.

Attachments (3)

selection_panels_cleanup.diff (47.3 KB ) - added by sanderd17 4 years ago.
selection_panels_cleanup.2.diff (48.9 KB ) - added by sanderd17 4 years ago.
selection_panels_cleanup.3.diff (48.9 KB ) - added by sanderd17 4 years ago.
Update to current SVN, revert all changes done to colour tags, implement some more remarks

Download all attachments as: .zip

Change History (5)

by sanderd17, 4 years ago

by sanderd17, 4 years ago

by sanderd17, 4 years ago

Update to current SVN, revert all changes done to colour tags, implement some more remarks

comment:1 by sanderd17, 4 years ago

Owner: set to sanderd17
Resolution: fixed
Status: newclosed

In 18254:

Restructure unit_actions.js. Fixes #4007

comment:2 by sanderd17, 4 years ago

Keywords: review removed
Note: See TracTickets for help on using tickets.