#4008 closed enhancement (fixed)
[PATCH] Missing unit action hotkeys
Reported by: | elexis | Owned by: | |
---|---|---|---|
Priority: | Nice to Have | Milestone: | Alpha 21 |
Component: | UI & Simulation | Keywords: | simple patch |
Cc: | Patch: |
Description (last modified by )
There are hotkeys for almost all unit actions (destroy, garrison, guard, ...), but some are missing: back-to-work, heal and capture. They should be added for completeness.
The most problematic part will be finding an unused key for back-to-work, see default.cfg
.
(heal and capture should be set to unused(#3051), as they are the default actions)
The files to modify can be found in binaries/data/mod/public/gui/session/
. unit_actions.js
should show that hotkey in the tooltips, see also r18252.
Attachments (7)
Change History (24)
comment:1 by , 8 years ago
comment:3 by , 8 years ago
Keywords: | review patch added |
---|---|
Milestone: | Backlog → Alpha 21 |
Summary: | Missing unit action hotkeys → [PATCH] Missing unit action hotkeys |
by , 8 years ago
Attachment: | missingunitactionhotkeys.patch added |
---|
Adds hotkeys as suggested by Imarok, and "Y" for rally point focusing
comment:4 by , 8 years ago
Notice #1720 suggesting Y = patrol, but maybe that one can use "P" as that seems to be unused for now.
comment:5 by , 8 years ago
comment:6 by , 8 years ago
- Your patch only adds the repair hotkey when setting up a rallypoint. When commanding a unit it doesn't work.
by , 8 years ago
Attachment: | missingunitactionhotkeys_v2.patch added |
---|
This is a fixed and rebased version of your patch
comment:7 by , 8 years ago
Keywords: | review removed |
---|
A repair hotkey should certainly work too when selecting units. It should have the same effect as when clicking on that button.
This however will conflict with other uses of Alt, for example Alt+doubleclick means selecting all units of that kind.
comment:8 by , 8 years ago
Keywords: | review added |
---|
by , 8 years ago
Attachment: | missingunitactionhotkeys_v2.2.patch added |
---|
Setting the rallypoint focus hotkey to unused (refs #3051)
by , 8 years ago
Attachment: | missingunitactionhotkeys_v2.3.patch added |
---|
Fixed some style mentioned by elexis in irc today
comment:10 by , 8 years ago
Keywords: | review removed |
---|---|
Milestone: | Alpha 21 → Backlog |
Type: | defect → enhancement |
Changes to the committed patch:
- Repairing is also expected to work with foundations
- It is unexpected that the hotkey does something other than pressing it does. But since this is the case for the other unit action buttons, we'll go with it.
default.cfg
: Ungarrisoning isn't a modifier.- Using
["Player", "Ally"]
instead of["Ally"]
for consistency (despite not being mandatory). Not switching toMutualAlly
since the simulation checks forAlly
too. - Notice the repair hotkey is actually useful and not equivalent to a simple right click as it allows forcing units to repair a building even if they could dropoff carried resources or capture it.
- Updated wiki:HotKeys.
Remaining TODO:
- No hotkey for back-to-work. That should be a useful one.
- Heal, capture, returnresource don't have hotkeys. Not sure if they are useful. Capture hotkeys probably, since a unit might be repairable and capturable at the same time f.e..
comment:11 by , 8 years ago
Description: | modified (diff) |
---|---|
Keywords: | patch removed |
Summary: | [PATCH] Missing unit action hotkeys → Missing unit action hotkeys |
comment:12 by , 8 years ago
Keywords: | review patch added |
---|---|
Milestone: | Backlog → Alpha 21 |
Summary: | Missing unit action hotkeys → [PATCH] Missing unit action hotkeys |
comment:13 by , 8 years ago
- Can you argue for the choice of the Y key
- Perhaps you can remove the dot at the end of L72
binaries/data/mods/public/gui/manual/intro.txt
(it's not in your patch but...)
comment:15 by , 8 years ago
Keywords: | review removed |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Thanks for all the patches! Closing the ticket as good enough for now. If we have the hotkey dialog, we can think about adding more.
comment:16 by , 7 years ago
(14:42:00) Grugnas: the only annoying thing is that u have to hold J for order your units to repair (14:42:14) Grugnas: pressing it 1 time only would be more comfortable
should be possible by calling g_EntityCommands.repair.execute()
if the hotkey is pressed instead of having it depend dynamically on the hotkey state like the garrison hotkey.
What about Alt + Right click for repairing and 'U' for unloading?