Missing unit action hotkeys

[elexis]

There are hotkeys for almost all unit actions (destroy, garrison, guard, ...), but some are missing: back-to-work, heal and capture. They should be added for completeness.

The most problematic part will be finding an unused key for back-to-work, see default.cfg. (heal and capture should be set to unused(#3051), as they are the default actions)

The files to modify can be found in binaries/data/mod/public/gui/session/. unit_actions.js should show that hotkey in the tooltips, see also r18252.

[Imarok]

What about Alt + Right click for repairing and 'U' for unloading?

[elexis]

That seems ok to me (especially since garrisoning works like that too).

[Sandarac]

Adds hotkeys as suggested by Imarok, and "Y" for rally point focusing

[elexis]

Notice #1720 suggesting Y = patrol, but maybe that one can use "P" as that seems to be unused for now.

[elexis]

Not sure whether we actually need an assigned key for the rallypoint. With #3051 / #3990 it could add an unassigned hotkey that could be assigned by people who really want that.

[Imarok]

• Your patch only adds the repair hotkey when setting up a rallypoint. When commanding a unit it doesn't work.

[Imarok]

This is a fixed and rebased version of your patch

[elexis]

A repair hotkey should certainly work too when selecting units. It should have the same effect as when clicking on that button.

This however will conflict with other uses of Alt, for example Alt+doubleclick means selecting all units of that kind.

[Imarok]

Uses "J" for repairing

[Imarok]

Setting the rallypoint focus hotkey to unused (refs #3051)

[Imarok]

Fixed some style mentioned by elexis in irc today

[elexis]

In 18578:

Hotkeys to repair, ungarrison and focus on the rallypoint. Patch by Imarok, refs #4008.

[elexis]

Changes to the committed patch:

• Repairing is also expected to work with foundations
• It is unexpected that the hotkey does something other than pressing it does. But since this is the case for the other unit action buttons, we'll go with it.
• default.cfg: Ungarrisoning isn't a modifier.
• Using ["Player", "Ally"] instead of ["Ally"] for consistency (despite not being mandatory). Not switching to MutualAlly since the simulation checks for Ally too.
• Notice the repair hotkey is actually useful and not equivalent to a simple right click as it allows forcing units to repair a building even if they could dropoff carried resources or capture it.
• Updated wiki:HotKeys.

Remaining TODO:

• No hotkey for back-to-work. That should be a useful one.
• Heal, capture, returnresource don't have hotkeys. Not sure if they are useful. Capture hotkeys probably, since a unit might be repairable and capturable at the same time f.e..

[Imarok]

Add a hotkey for back-to-work