[PATCH] Phoenician levant has unreachable trees

[sanderd17]

Pheonician levant (or was it Phoenician) has a lot of unreachable trees on the map boundary.

It's easy to find them via the obstruction overlay.

This is because on square maps, there's a border of 3 tiles wide that's unpassable and allows the terrain to fade to black.

The following patch should fix it (apparently map size is expressed in tiles instead of meters?).

[sanderd17]

First patch messes up mountains on the edge, second patch doesn't

[FeXoR]

I guess adding a constant mapBorderShadowWidth, making it the default parameter for the distance parameter in Map.validT and use that for both, round and rectangular maps would be better. That also will require thorough testing especially on round maps of different sizes and the edges of rectangular maps to ensure we didn't overlook some behavoir of the engine we didn't expect.

[FeXoR]

Just uses the distance parameter instead of a hardcoded 3

[FeXoR]

That last patch fixes an issue not taking into account the distanceparameter on rectangular maps. AFAIK that fixes the issue. Thanks sanderd17 for notifying me about this issue, the ticket and the patch.

[FeXoR]

In 18312:

Fixes a bug for random maps where Map.validT didn't apply the distance parameter properly on rectangular maps. Fixes #4012

[sanderd17]

Apparently the patch is broken, the majority of resources don't appear on the map after this patch. Only a few bushes appear on the map.

[FeXoR]

Fixes the unhandled case if distance is not given

[FeXoR]

ALTERNATIVE patch also renaming (mv) phoenician_levant.js/json to fix the typo

[FeXoR]

In 18360:

Fixes a bug introduced in r18312 that prevents entity placement on some rectangular maps e.g. Phoenician Levant and Corsica vs Sardinia. Also fixes a typo in the Phoenician Levant .js and .json files. Fixes #4012

[fatherbushido]

It looks like i have still the same bug but at bottom of the map now

[sanderd17]

@fatherbushido: it's not exactly the same bug. In the old bug, the trees never became visible as they were beyond the SoD edge.

It looks that in your case, the trees are placed exactly on the map boundary, creating little space for the units to gather the trees, and causing the units to block each other from movements.

It should be perfectly possible to gather the tree with a single unit in your case, so I'm not convinced this issue should be solved in the map. It should rather be solved in the UnitAI, UnitMotion and/or pathfinder.

[FeXoR]

Fixes SimpleObject.place() placing entities outside playable map and add const MAP_BORDER_WIDTH

[FeXoR]

Fixed in changeset r18450

[elexis]

refs r20283, #4814