[PATCH] Siege Engines are not shown in the summary

[Imarok]

1. Siege Engines should be listed in the summary
2. The captured statistic for Siege Engines should be displayed/created too

team summary fixed:

[Mate-86]

feedback from bb_:

• captureable summary for Siege units and Total only
• horizontal ordering of unit types could be changed to "... siege, naval, trader"
• need to double check values printed (captured are marked as lost for the other player)
• units and building headers need to be in the same order

[Mate-86]

v2

[Mate-86]

Some open points:

• not sure whether I should update some unit tests for JS?
• I've modified counter.js:calculateUnitsTeam as well but I don't know how to test it. Should I setup a match with teams?
• There is a slight misalignment on my latest screenshot. I may need help how to align the counters to the center.

[elexis]

Replying to Mate-86:

not sure whether I should update some unit tests for JS?

We don't have tests for the GUI yet and it's not the purpose of this ticket to lie the foundation to that.

I've modified counter.js:calculateUnitsTeam as well but I don't know how to test it. Should I setup a match with teams?

Yes

There is a slight misalignment on my latest screenshot. I may need help how to align the counters to the center.

Been there, #3351, nuke the trailing newline probably.

[Mate-86]

I've uploaded a new patch. Removing the newline has solved the problem but I could not check the team summary page even if I set up some teams. If no objection I'd move the ticket to review queue.

[Imarok]

Have you set Locked Teams to true?

[Mate-86]

Thx, now I get the team summary as well. Need to apply some further fixes tomorrow.

[Mate-86]

Team summary fixed as well, screenshot and latest patch attached.

[bb]

counters.js L235-6 trailing whitespace + 1 newline is enough. L240, L243, L252, L254, L259: trailing whitespace

StatisticsTracker.js L352: trailing whitespace L355 indentation error

When the values start to get bigger e.g. get more digits the 4 values does not fit anymore on the one line. The lost vale will then fall of the line to the next line but it is only half visible then. It might be nice to split out the values over different lines as is done in the structure tab.

[Mate-86]

New solution (screenshot + patch) uploaded. Whitespace issues should be fixed as well.

[bb]

counters.js L251 trailing whitespace

Further is ok so pushing to review queue.

[elexis]

In 18780:

Siege statistics for the summary screen. Patch by Mate-86, fixes #4033.

[elexis]

Thanks for the patch!