Opened 14 years ago

Closed 6 years ago

Last modified 6 years ago

#404 closed defect (fixed)

Makefile build system should have pyrogenesis/test targets depend on Collada

Reported by: Philip Taylor Owned by: Itms
Priority: Should Have Milestone: Alpha 23
Component: Build & Packages Keywords:
Cc: Patch:

Description (last modified by Itms)

The Collada target is a run-time dependency for pyrogenesis and test, so it ought to get built automatically when people run make pyrogenesis and make test. Currently it doesn't.

It's not a build-time dependency for the executables, and shouldn't be used when linking, so Premake's package.links does not seem to be a suitable place to put it. Is there another way? or maybe Premake needs to be patched to support non-linking dependencies?

Attachments (1)

404.patch (42.2 KB ) - added by Alan Jacobs Richardson 11 years ago.
Add "deps" option to premake projects. Also beef up .gitignore a little.

Download all attachments as: .zip

Change History (16)

comment:1 by (none), 13 years ago

Milestone: Open Source Release

Milestone Open Source Release deleted

comment:2 by Andrew, 13 years ago

Milestone: Backlog

comment:3 by historic_bruno, 11 years ago

Component: Core engineBuild & Packages

by Alan Jacobs Richardson, 11 years ago

Attachment: 404.patch added

Add "deps" option to premake projects. Also beef up .gitignore a little.

comment:4 by Alan Jacobs Richardson, 11 years ago

A bit of searching around turned up this feature request for premake: http://sourceforge.net/p/premake/feature-requests/148/

So premake does need to be patched for this. Checking their dev repository just now, I see that a similar feature is already there, so you may want to use that instead. (https://bitbucket.org/premake/premake-dev/src/5c0c8d6a5254378d49aa6eb7e2b9effc3a6e38c1/src/base/project.lua?at=default#cl-211)

comment:5 by historic_bruno, 11 years ago

Keywords: patch review added
Milestone: BacklogAlpha 15
Summary: Makefile build system should have pyrogenesis/test targets depend on Collada[PATCH] Makefile build system should have pyrogenesis/test targets depend on Collada

comment:6 by wraitii, 10 years ago

Milestone: Alpha 15Alpha 16

comment:7 by leper, 10 years ago

Milestone: Alpha 16Alpha 17

comment:8 by leper, 10 years ago

Milestone: Alpha 17Alpha 18

comment:9 by leper, 9 years ago

Milestone: Alpha 18Alpha 19

The patch doesn't look too bad, making the variable naming and premake function a bit closer to upstream would be nice (also regarding #1518). But as we are currently in feature freeze I'll push this to A19 and take a closer look at it then.

comment:10 by Itms, 9 years ago

Milestone: Alpha 19Alpha 20

comment:11 by Itms, 8 years ago

Milestone: Alpha 20Alpha 21

comment:12 by Itms, 8 years ago

Keywords: simple review removed
Milestone: Alpha 21Backlog

This should wait for #3729.

comment:13 by Itms, 7 years ago

Keywords: patch removed
Milestone: BacklogWork In Progress
Summary: [PATCH] Makefile build system should have pyrogenesis/test targets depend on ColladaMakefile build system should have pyrogenesis/test targets depend on Collada

A fix is included to the patch at #3729, and it will be effective as soon as premake5 becomes the default.

comment:14 by Itms, 6 years ago

Owner: set to Itms
Resolution: fixed
Status: newclosed

In 20381:

Migrate to premake5, fixes #3729.
Make pyrogenesis and tests depend on Collada, fixes #404.

This commit includes custom modules for CxxTest and pkg-config support that can be improved upon in the future. It also includes all necessary changes to the build scripts, but the new premake5 features are not fully exploited yet.

With this change, premake5 becomes the default, but CI scripts on Unix will continue using premake4 for a while, in order to avoid regressions.

Includes code by zsol.
Reviewed by: wraitii, leper
Differential Revision: https://code.wildfiregames.com/D72

comment:15 by Itms, 6 years ago

Description: modified (diff)
Milestone: Work In ProgressAlpha 23
Note: See TracTickets for help on using tickets.