Opened 18 months ago

Closed 18 months ago

Last modified 18 months ago

#4052 closed defect (fixed)

[PATCH] Player color of garrisoned units not visible when the player does not control them

Reported by: mimo Owned by: elexis
Priority: Nice to Have Milestone: Alpha 21
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description

When allied units are garrisoned inside an allied building, the unload button is disabled, which makes that we can't see the unit owner color. When playing with several allies, that info is useful. As the unload order already checks that we can control the units, there is no gain to disable this button, and thus removing lines 436-438 of selection_panels.js would allow to display the owner color in all cases.

In addition, the tooltip should be changed when we do not control the unit: the line (429) indicating that we should click to unload must be removed (and maybe something saying that we can't unload the unit added).

Attachments (1)

t4051_disabled_sprite_v1.patch (1.9 KB) - added by elexis 18 months ago.
Shows the player color in the sprite_disabled, adds the grayscale again and shows only the unit name in the tooltip if disabled. Refs r18347 #3731 #3168.

Download all attachments as: .zip

Change History (4)

Changed 18 months ago by elexis

Shows the player color in the sprite_disabled, adds the grayscale again and shows only the unit name in the tooltip if disabled. Refs r18347 #3731 #3168.

comment:1 Changed 18 months ago by elexis

Keywords: patch review added; simple removed
Priority: Should HaveNice to Have
Summary: Player color of garrisoned units not visible when the player does not control them[PATCH] Player color of garrisoned units not visible when the player does not control them

comment:2 Changed 18 months ago by elexis

Owner: set to elexis
Resolution: fixed
Status: newclosed

In 18362:

Show the player color and name of units from other players garrisoned in allied buildings. Fixes #4052.

comment:3 Changed 18 months ago by elexis

Keywords: review removed

Thanks mimo for a quick review on irc.

Note: See TracTickets for help on using tickets.