Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#4068 closed enhancement (fixed)

[PATCH] Prepare random map lib map.js for further libraries

Reported by: FeXoR Owned by: FeXoR
Priority: Should Have Milestone: Alpha 21
Component: Maps Keywords: patch
Cc: Patch:

Description

This patch splits getFullEntityList() - gathering all entities including those placed with terrain - from getMapData().

This is a prerequirement of two libs (and an addition of functionality on it's own):

  • beautifier.js by wraitii placing matching actors arround present entities
  • collision.js a debug lib that detects overlapping entities - like the good old chicken in civic centre

Attachments (1)

map.js2016-6-21.patch (1.3 KB ) - added by FeXoR 8 years ago.
Splits entity/actor gathering from map export

Download all attachments as: .zip

Change History (7)

by FeXoR, 8 years ago

Attachment: map.js2016-6-21.patch added

Splits entity/actor gathering from map export

comment:1 by Imarok, 8 years ago

shouldn't let used in favour of var?

comment:2 by FeXoR, 8 years ago

shouldn't let used in favour of var?

I just used the syntax of that file. IIRC that is of higher priority, not sure. My experience tells me that changing the syntax of a file with a change in functionallity will never get reviewed.

comment:3 by FeXoR, 8 years ago

Owner: set to FeXoR
Resolution: fixed
Status: newclosed

In 18437:

Separate getFullEntityList() - gathering all entities placed until now on a random map in a list - from getMapData(). Preparation for committing collision detection and beautifier patches. Fixes #4068

comment:4 by FeXoR, 8 years ago

Keywords: review removed

comment:5 by Palaxin, 8 years ago

Milestone: Backlog

comment:6 by elexis, 8 years ago

Milestone: Alpha 21
Summary: [PATCH} Prepare random map lib map.js for further libraries[PATCH] Prepare random map lib map.js for further libraries
Note: See TracTickets for help on using tickets.