| 1 | | Replying to [comment:5 bb]: |
| 2 | | > Templates.js |
| 3 | | > L308 and further for consistence it might be good to make upgrades an object instead of an array, have no strong opinion on it. |
| 4 | | > |
| 5 | | > Draw.js |
| 6 | | > L90 ++p instead of p++ |
| 7 | | > |
| 8 | | > Structree.js |
| 9 | | > L229-241 why braces? |
| 10 | | > L237 !newUpgrades[phase] instead of !(phase in newUpgrades) |
| 11 | | > L285 gives folowing error: |
| 12 | | > {{{ |
| 13 | | > ERROR: JavaScript error: gui/structree/structree.js line 285 |
| 14 | | > ReferenceError: GetPhaseOfTemplate is not defined |
| 15 | | > selectCiv@gui/structree/structree.js:285:9 |
| 16 | | > __eventhandler38 (selectionchange)@civSelection selectionchange:0:1 |
| 17 | | > init@gui/structree/structree.js:38:3 |
| 18 | | > __eventhandler8 (press)@menuStrucTreeButton press:2:8 |
| 19 | | > ERROR: GUI page 'page_structree.xml': Failed to call init() function |
| 20 | | > }}} |
| 21 | | > The called function does not seem to exist, probably cause of #3393. |
| 22 | | > |
| 23 | | > |
| 24 | | > Didn't test due to error. |
| | 1 | Templates.js |
| | 2 | L308 and further for consistence it might be good to make upgrades an object instead of an array, have no strong opinion on it. |
| | 3 | |
| | 4 | Draw.js |
| | 5 | L90 ++p instead of p++ |
| | 6 | |
| | 7 | Structree.js |
| | 8 | L229-241 why braces? |
| | 9 | L237 !newUpgrades[phase] instead of !(phase in newUpgrades) |
| | 10 | L285 gives folowing error: |
| | 11 | {{{ |
| | 12 | ERROR: JavaScript error: gui/structree/structree.js line 285 |
| | 13 | ReferenceError: GetPhaseOfTemplate is not defined |
| | 14 | selectCiv@gui/structree/structree.js:285:9 |
| | 15 | __eventhandler38 (selectionchange)@civSelection selectionchange:0:1 |
| | 16 | init@gui/structree/structree.js:38:3 |
| | 17 | __eventhandler8 (press)@menuStrucTreeButton press:2:8 |
| | 18 | ERROR: GUI page 'page_structree.xml': Failed to call init() function |
| | 19 | }}} |
| | 20 | The called function does not seem to exist, probably cause of #3393. |
| | 21 | |
| | 22 | |
| | 23 | Didn't test due to error. |
