[PATCH] Show Upgrade in Structure Tree

[fatherbushido]

Since r18467, there is an Upgrade component. Currently it is used for the wall gate.

We can can remove the current gate in the structure tree and show the upgrade (i guess only for structure and not for units).

[elexis]

While at it, the resource costs for the gate should be removed as gates can't be placed directly.

[s0600204]

Proposed patch. Requires #3993 patch v4.1

[s0600204]

Patch displays the upgrade options of any structure (or wallset) that has them. (Works with fatherbushido's patch for #4125)

Patch also displays any units with upgrade options, alongside the trainer units down the right-hand side.

And I've disabled the cost component for Gates.

[fatherbushido]

Just a quick remark, we let a cost component for Gates to prevent instantaneous repair.

[s0600204]

Good point.

Does the repair need a resource and a time, or just a time? I ask because palisade gates are built/upgraded with wood, but have stone (and no wood) in their Cost.

[s0600204]

Suppress the stone cost in Gate template. (*Seriously* the correct patch this time.)

[bb]

Templates.js L308 and further for consistence it might be good to make upgrades an object instead of an array, have no strong opinion on it.

Draw.js L90 ++p instead of p++

Structree.js L229-241 why braces? L237 !newUpgrades[phase] instead of !(phase in newUpgrades) L285 gives folowing error:

ERROR: JavaScript error: gui/structree/structree.js line 285
ReferenceError: GetPhaseOfTemplate is not defined
  selectCiv@gui/structree/structree.js:285:9
  __eventhandler38 (selectionchange)@civSelection selectionchange:0:1
  init@gui/structree/structree.js:38:3
  __eventhandler8 (press)@menuStrucTreeButton press:2:8
ERROR: GUI page 'page_structree.xml': Failed to call init() function

The called function does not seem to exist, probably cause of #3393.

Didn't test due to error.

[elexis]

Moving to alpha 22 as long as #3993 is there as well.

[elexis]

Perhaps I find time to review it. The tower upgrade should be shown there.

[elexis]

#3993, I forgot, too bad.

[elexis]

Moving to the new WIP milestone.

[fatherbushido]

s0600204: We can reinvest that one now. Does it need some rebasing/cleaning before?

[s0600204]

Rebase after Tech Reqs work (#4263) was merged into main trunk

[s0600204]

Patch ported to Phabricator: ​D92 Please direct further feedback there.

[s0600204]

Committed in r19600

[s0600204]

In 19711:

Fix rP19600 not handling upgradeable units correctly.

Tested By: wowgetoffyourcellphone
Refs: #4079
Differential Revision: ​https://code.wildfiregames.com/D517