Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#4100 closed defect (fixed)

[PATCH] Merge big house templates

Reported by: elexis Owned by: elexis
Priority: Should Have Milestone: Alpha 21
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description

The civ-specific templates for big houses are duplicate and should use a new parent template.

See also #4016, #4021, #4022.

While at it we can observe strange values there, for example <Max>1091</Max> and <BuildTime>53</BuildTime> for hellenic houses. This in fact means that that the +10% structure health and 10% buildtime malus from civbonus_hellenic_architecture.json is actually reverted in the templates, so that it will come out as 1200 Health and 60 seconds.

This is bad practice as the json file should be independent from the templates (briefly discussed on irc with sanderd17 on july 10th).

So the big houses could just be all 1000 Health or 1200 Health (with +10% more for hellenic civs) and the buildtime could be reduced to 50s.

Attachments (2)

mergebighouses.patch (6.6 KB ) - added by Sandarac 8 years ago.
This adds a big house template, and the Hellenic Architecture civbonus results in 1100 health and 56 second build time for Hellenic Civs. Cart and Pers houses have a unique obstruction and footprint, so I left those.
mergebighouses_v0.2.patch (6.6 KB ) - added by Sandarac 8 years ago.
Gives big houses 1200HP.

Download all attachments as: .zip

Change History (6)

by Sandarac, 8 years ago

Attachment: mergebighouses.patch added

This adds a big house template, and the Hellenic Architecture civbonus results in 1100 health and 56 second build time for Hellenic Civs. Cart and Pers houses have a unique obstruction and footprint, so I left those.

comment:1 by Sandarac, 8 years ago

Keywords: rfc patch added
Milestone: BacklogAlpha 21
Summary: Merge big house templates[PATCH] Merge big house templates

comment:2 by elexis, 8 years ago

Cc: Palaxin removed
Keywords: review added; rfc removed

Tested, confirmed, can be committed, but I would propose 1200HP instead of 1000HP as small houses already get 800HP while costing half the res. Small house templates look all fine to me too.

Commit message:

Move duplicate big house templates to a new parent. Patch by Sandarac, fixes #4100.

Also remove the revert of the civbonus_hellenic_architecture.json in the hellenic house templates (1091 Health * 1,1 = 1200 Health),
since the templates should be independent from the number of the json file (thus add 10% more HP to the hellenic houses).
Construct big houses in 50 (respectively 55) seconds instead of 60 seconds.

Alternatively the health points of small houses could be reduced from 800 to 600.

Last edited 8 years ago by elexis (previous) (diff)

by Sandarac, 8 years ago

Attachment: mergebighouses_v0.2.patch added

Gives big houses 1200HP.

comment:3 by elexis, 8 years ago

Owner: set to elexis
Resolution: fixed
Status: newclosed

In 18517:

Merge duplicate big house templates. Patch by Sandarac, reviewed by mimo, fixes #4100.

While at it, remove the revert of the civbonus_hellenic_architecture.json in the hellenic house templates (1091 Health * 1,1 = 1200 Health),
since the templates should be independent from the number of the json file (thus restore the missing 10% bonus for hellenic houses).
Construct big houses in 50 (respectively 55) seconds instead of 60 seconds for the same reason (and using a number that is more round than 53 without increasing the buildtime).

comment:4 by elexis, 8 years ago

Keywords: simple review removed

Thanks for the quick (yet (apparently) perfect) fix!

Note: See TracTickets for help on using tickets.