Opened 8 years ago

Closed 5 years ago

Last modified 5 years ago

#4101 closed enhancement (fixed)

[PATCH] sound notification when people join hosted game menu

Reported by: Andy Alt Owned by: Polakrity
Priority: Nice to Have Milestone: Alpha 24
Component: UI & Simulation Keywords:
Cc: Patch: Phab:D821, Phab:D932

Description (last modified by elexis)

I think it would be helpful to have an audible alert when someone joins a hosted game lobby. I'd feel more free to minimize the window while checking on various other things while I"m waiting for the room to fill up. What other advantages would there be to this feature?

The forum thread for this patch: Link

Attachments (4)

JoinGameAlert.patch (953 bytes ) - added by Andy Alt 8 years ago.
JoinGameAlert.2.patch (1.7 KB ) - added by Andy Alt 8 years ago.
option added
JoinGameAlert.3.patch (1.7 KB ) - added by Andy Alt 8 years ago.
JoinGameAlert.4.patch (1.7 KB ) - added by Andy Alt 8 years ago.
applying Imarok's suggestion

Download all attachments as: .zip

Change History (21)

comment:1 by Andy Alt, 8 years ago

Keywords: simple added

comment:2 by Andy Alt, 8 years ago

Keywords: patch added
Milestone: BacklogAlpha 21
Owner: set to Andy Alt
Status: newassigned
Summary: sound notification when people join hosted game menu[PATCH] sound notification when people join hosted game menu

comment:3 by Andy Alt, 8 years ago

Forum post for this patch: Link

by Andy Alt, 8 years ago

Attachment: JoinGameAlert.patch added

comment:4 by Andy Alt, 8 years ago

Description: modified (diff)
Keywords: rfc added

by Andy Alt, 8 years ago

Attachment: JoinGameAlert.2.patch added

option added

by Andy Alt, 8 years ago

Attachment: JoinGameAlert.3.patch added

comment:5 by Imarok, 8 years ago

patch looks good and works Only remark: L751: if (Engine.ConfigDB_GetValue("user", "sound.notify.join") == "true") should be if (Engine.ConfigDB_GetValue("user", "sound.notify.join"))

by Andy Alt, 8 years ago

Attachment: JoinGameAlert.4.patch added

applying Imarok's suggestion

comment:6 by Imarok, 8 years ago

Keywords: review added; rfc removed

I tested it and it works perfectly The code seems to be ok too

comment:7 by Andy Alt, 8 years ago

Description: modified (diff)

comment:8 by Imarok, 8 years ago

You should add an entry in default.cfg for this option. (like you've done in r18545)

comment:9 by elexis, 8 years ago

This will presumably not be the last acoustical notification when something happens (f.e. #4159). If we were to continue adding one global and that check for every notification type, it would become a bit messy.

The code that the patch shares with r18545 should be merged. Instead of 2 globals for the times, it could use a global object where the keys are the names of the default.cfg entries:

var g_NotificationTimes = {
	"nick": ...,
	"join": timestamp
}

and use a function that gets passed the config entry and soundfile string.

comment:10 by Imarok, 8 years ago

Keywords: review removed

comment:11 by Andy Alt, 8 years ago

Owner: Andy Alt removed
Status: assignednew

comment:12 by elexis, 8 years ago

Milestone: Alpha 21Backlog

comment:13 by elexis, 7 years ago

Component: Music & Sound FXUI & Simulation
Description: modified (diff)
Keywords: simple removed
Milestone: BacklogWork In Progress
Patch: Phab:D821

comment:14 by bb, 7 years ago

The cleanup proposed above in r20226

Patch By: Polakrity

Reviewed By: elexis, bb

Differential Revision: https://code.wildfiregames.com/D821

Last edited 7 years ago by bb (previous) (diff)

comment:15 by Polakrity, 7 years ago

Owner: set to Polakrity
Patch: Phab:D821Phab:D821, Phab:D932
Status: newassigned

comment:16 by Imarok, 5 years ago

Resolution: fixed
Status: assignedclosed

In 22088:

Acoustic notification when people join a hosted game

Patch by Polakrity.
Sound by Samulis.
Reviewed by: Imarok

Fixes: #4101
Differential Revision: https://code.wildfiregames.com/D932

comment:17 by Stan, 5 years ago

Keywords: patch removed
Milestone: Work In ProgressAlpha 24
Note: See TracTickets for help on using tickets.