Phase requirements tooltip disappeared

[elexis]

To advance to town phase, one needs to build 5 buildings. Up to alpha 20 there was a tooltip showing the number of remaining buildings needed, but that isn't shown anymore.

See selection_panels.js L763 (Remaining: %(number)s to build)

Thanks _kali for reporting.

[fatherbushido]

In Template.js L374-L378 template.requirements.class will not get the class requirements if they are like "requirements": { "all": [{ "class": "Village", "number": 5 }, { "notciv": "athen" }] } So L766, if (template.classRequirements) will be false. For the unlock_shared_dropsite tech the requrements are "requirements": { "class": "Trader", "number": 3 } so we don't have this problem.

[fatherbushido]

So :

• Template.js don't handle class requirements when they are in an "any" or "all" array.
• Moreover, in selection_panels (L766 - L773), we should handle an array of class requirements

[fatherbushido]

refs #3993 (patch v4)

[Itms]

Moving to A22 since #3993 has been pushed. Also removing the simple keyword, so new contributors don't waste time on this one.

[elexis]

Workaround was added in r18847, #3993/#4263 should fix it properly.

[elexis]

In r19120 by fatherbushido:

Merge different logics of technology requirements and fix the related bugs. Create a global script which derive the technology requirements objects in a form usable for structure tree, gui, simulation and AI. Reviewed by mimo (for AI) and fatherbushido. Fixes #3993, #1646, #4263, #4217. Refs #4108.